Closed
Bug 1384977
Opened 7 years ago
Closed 7 years ago
PreviewProvider.jsm should be removed before 56 goes to beta
Categories
(Firefox :: New Tab Page, enhancement)
Firefox
New Tab Page
Tracking
()
RESOLVED
FIXED
Firefox 56
Tracking | Status | |
---|---|---|
firefox56 | --- | fixed |
People
(Reporter: dmosedale, Assigned: dmosedale)
References
Details
Attachments
(1 file)
It's no longer needed by activity stream, and the whitelist entry will make the builds break.
Comment 1•7 years ago
|
||
ursula should know at least which files need to be touched. Something with tests and its related browser.ini I believe.
Flags: needinfo?(usarracini)
Comment hidden (mozreview-request) |
Assignee | ||
Comment 3•7 years ago
|
||
Not yet tested; I've just triggered a try run.
Assignee | ||
Comment 4•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=1bc4ed58e66301d0ecf5bdb33e3f5302ab4876bb
Comment hidden (mozreview-request) |
Comment 6•7 years ago
|
||
Yeah you'll need to remove it from browser/components/newtab/tests/browser/browser.ini as well Dan
Flags: needinfo?(usarracini)
Comment hidden (mozreview-request) |
Assignee | ||
Comment 8•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=3ba311327d5c8b02503d29c24d27265f860edebd
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Comment 11•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=03772e0238c63bad4b4af7218196ca7fed0c6330
Comment 12•7 years ago
|
||
mozreview-review |
Comment on attachment 8890922 [details] Bug 1384977 - Remove unused PreviewProvider.jsm and refs, ? https://reviewboard.mozilla.org/r/162128/#review167428 Looks good to me! R+ as long as try build is happy. Thanks!
Attachment #8890922 -
Flags: review?(usarracini) → review+
Comment 13•7 years ago
|
||
Pushed by dmosedale@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/cfd698429f63 Remove unused PreviewProvider.jsm and refs, r=ursula?
Comment 14•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/cfd698429f63
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
Comment 15•7 years ago
|
||
Fixed with https://github.com/mozilla/activity-stream/pull/2994 to be uplifted via bug 1385133.
Blocks: 1385133
Updated•5 years ago
|
Component: Activity Streams: Newtab → New Tab Page
You need to log in
before you can comment on or make changes to this bug.
Description
•