Closed Bug 1384977 Opened 2 years ago Closed 2 years ago

PreviewProvider.jsm should be removed before 56 goes to beta

Categories

(Firefox :: New Tab Page, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
Firefox 56
Tracking Status
firefox56 --- fixed

People

(Reporter: dmose, Assigned: dmose)

References

Details

Attachments

(1 file)

It's no longer needed by activity stream, and the whitelist entry will make the builds break.
ursula should know at least which files need to be touched. Something with tests and its related browser.ini I believe.
Flags: needinfo?(usarracini)
Not yet tested; I've just triggered a try run.
Yeah you'll need to remove it from browser/components/newtab/tests/browser/browser.ini as well Dan
Flags: needinfo?(usarracini)
Blocks: 1343150
Comment on attachment 8890922 [details]
Bug 1384977 - Remove unused PreviewProvider.jsm and refs, ?

https://reviewboard.mozilla.org/r/162128/#review167428

Looks good to me! R+ as long as try build is happy. Thanks!
Attachment #8890922 - Flags: review?(usarracini) → review+
Pushed by dmosedale@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cfd698429f63
Remove unused PreviewProvider.jsm and refs, r=ursula?
https://hg.mozilla.org/mozilla-central/rev/cfd698429f63
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
Component: Activity Streams: Newtab → New Tab Page
You need to log in before you can comment on or make changes to this bug.