1385034 - Write reflow tests for the tab strip when it overflows and underflows

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, enhancement, P1)

Description

[Mike Conley (:mconley) (:⚙️)]

Bug 1356705 is required since this allows us to get a deterministic number of reflows when scrolling the tab strip.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1385034 - Add a reflow test for when the tabstrip over and underflows.

Review commit: https://reviewboard.mozilla.org/r/162180/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/162180/

Comment 2

[:Gijs (he/him)]

Comment on attachment 8891007 [details]
Bug 1385034 - Add a reflow test for when the tabstrip over and underflows.

https://reviewboard.mozilla.org/r/162180/#review167970

::: browser/base/content/test/performance/browser_tabstrip_overflow_underflow_reflows.js:103
(Diff revision 1)
> + * This test ensures that there are no unexpected
> + * uninterruptible reflows when opening a new tab that will
> + * cause the existing tabs to overflow and the tab strip to
> + * become scrollable. It also tests that there are no
> + * unexpected uninterruptible reflows when closing that tab,
> + * which causes the tab strip to underflow.

In this the nittiest of nits,
could you rewrap this comment
so it has longer lines and is
not split over quite so many
separate lines making it
unnecessarily hard to scan?
;-)

(the code goes up to 96 chars per line, and 76-80 in many places, and the comment maxes out at 60)

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8891007 [details]
Bug 1385034 - Add a reflow test for when the tabstrip over and underflows.

https://reviewboard.mozilla.org/r/162180/#review167970

> In this the nittiest of nits,
> could you rewrap this comment
> so it has longer lines and is
> not split over quite so many
> separate lines making it
> unnecessarily hard to scan?
> ;-)
> 
> (the code goes up to 96 chars per line, and 76-80 in many places, and the comment maxes out at 60)

Good catch! Had my editor zoomed in, so I think I got a bit overzealous on the wrapping. :)

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8891007 [details]
Bug 1385034 - Add a reflow test for when the tabstrip over and underflows.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/162180/diff/1-2/

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8891007 [details]
Bug 1385034 - Add a reflow test for when the tabstrip over and underflows.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/162180/diff/2-3/

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0050487d9369
Add a reflow test for when the tabstrip over and underflows. r=Gijs

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0050487d9369