1385124 - Mobile firefox deeplinks are redirecting to alternate-app links which are not closing by themselves after redirecting to app

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect, P2)

Description

[Purnima Yadla]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/59.0.3071.115 Safari/537.36

Steps to reproduce:

Device: Any Android device
OS version: 4.4.2 & higher
Firefox browser version: 54.0.1

1) Go to playstore and install the Amazon music Android app
2) Sign in using a valid Amazon account
3) Open following deeplink url by copying and pasting it in firefox browser:
https://music.amazon.com/playlists/B01HZXDWGS?do=play&ref=dm_sh_ssddeerrttff0playlistplay&tag=playlistPlay&DEEPVIEWSAB_107318=T1


Actual results:

Deeplink opens a deepview which promptly redirects to an alternate-app.link url upon app detection, which then opens the Amazon music app

After going to the music app when we press back button we see a blank page.
Blank page persists until two more back button clicks after which we are taken back to the deepview


Expected results:

Deeplink opens a deepview which promptly opens the Amazon music app
Any 307 redirects that happen in between should be killed upon app detection before redirecting to app.

Comment 1

[Joe Cheng [:jcheng] (please needinfo)]

probably need both platform/front-end to look into this? ni snorp and nechen

Comment 2

[evan_layman]

We are able to reproduce this behavior in another flow if that is helpful too. You need not have the Amazon Music app installed on Android, so just follow these steps:

1. Navigate Firefox to https://music.amazon.com/embed/B01HZXDWGS
2. Tap on the album art
3. A new tab is opened (due to target="_blank" on the link) which returns 307 redirect to app store intent URI

Expected: The new tab should close itself since it has no HTML content and is opening another app

Actual: new blank tab stays open and app store opens. Upon hitting back button, the blank tab is present and confusing.

Comment 3

[James Willcox (:snorp) ([e-mail]) (he/him)]

Jim can you see if there's something we can do?

Comment 4

[evan_layman]

Bump any update?

Comment 5

[(inactive) Jim Chen [:jchen] [:darchons]]

Looking into it

Comment 6

[Purnima Yadla]

Any updates or ETA?

Comment 7

[Purnima Yadla]

You can compare with testing the above mentioned url in Chrome browser for expected behavior.

Comment 8

[(inactive) Jim Chen [:jchen] [:darchons]]

The problem mentioned in comment 0 seems to be fixed in Nightly? If I open that link, the music app opens, but if I press back, it goes back to the mobile site directly; there are no blank pages in-between.

The problem mentioned in comment 2 is still there, pressing back returns to the blank page that the target=_blank link opened.

Comment 9

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Bug 1385124 - Close tab when new tab redirects to external app;

When a site opens link in a new tab that redirects to an external app,
we should close the new (empty) tab and return to the previous page.

Review commit: https://reviewboard.mozilla.org/r/184214/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/184214/

Comment 10

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8912893 [details]
Bug 1385124 - Close tab when new tab redirects to external app;

https://reviewboard.mozilla.org/r/184214/#review189672

LGTM.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6e019978b9d3
Close tab when new tab redirects to external app; r=sebastian

Comment 12

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/6e019978b9d3

Comment 13

[[Back July 11] Ryan VanderMeulen]

Is this something that we should nominate for Beta approval or can it ride the 58 train?

Comment 14

[(inactive) Jim Chen [:jchen] [:darchons]]

Let it ride the train IMO.