|Submitter||Diff||Changes||Open Issues||Last Updated|
|Error loading review requests:|
59 bytes, text/x-review-board-request
|Details | Review|
This flag was added in alexcrichton/cargo-vendor#37 (since 0.1.11).
Comment on attachment 8891123 [details] Bug 1385131 - Use --version for checking version of cargo-vendor. https://reviewboard.mozilla.org/r/162306/#review172816 ::: python/mozbuild/mozbuild/vendor_rust.py:45 (Diff revision 1) > def check_cargo_vendor_version(self, cargo): > ''' > Ensure that cargo-vendor is new enough. cargo-vendor 0.1.11 and newer > strips out .orig and .rej files which we want. > ''' > - for l in subprocess.check_output([cargo, 'install', '--list']).splitlines(): > + out = subprocess.check_output([cargo, 'vendor', '--version']).splitlines() I don't think this will actually work properly. If `cargo-vendor` isn't installed, this will raise an exception and that's not handled anywhere.
Attachment #8891123 - Flags: review?(ted) → review-
You need to log in before you can comment on or make changes to this bug.