1385131 - Use cargo vendor --version to check version of cargo-vendor

Status: RESOLVED WONTFIX

(Firefox Build System :: General, enhancement)

Description

[Xidorn Quan [:xidorn] UTC+11]

This flag was added in alexcrichton/cargo-vendor#37 (since 0.1.11).

Comment 1

[Xidorn Quan [:xidorn] UTC+11]

Attachment: Bug 1385131 - Use --version for checking version of cargo-vendor.

Review commit: https://reviewboard.mozilla.org/r/162306/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/162306/

Comment 2

[(not currently active) Ted Mielczarek]

Comment on attachment 8891123 [details]
Bug 1385131 - Use --version for checking version of cargo-vendor.

https://reviewboard.mozilla.org/r/162306/#review172816

::: python/mozbuild/mozbuild/vendor_rust.py:45
(Diff revision 1)
>      def check_cargo_vendor_version(self, cargo):
>          '''
>          Ensure that cargo-vendor is new enough. cargo-vendor 0.1.11 and newer
>          strips out .orig and .rej files which we want.
>          '''
> -        for l in subprocess.check_output([cargo, 'install', '--list']).splitlines():
> +        out = subprocess.check_output([cargo, 'vendor', '--version']).splitlines()[0]

I don't think this will actually work properly. If `cargo-vendor` isn't installed, this will raise an exception and that's not handled anywhere.

Comment 3

[Mike Hommey [:glandium]]

Bug 1574056 obsoletes the need for this.