Use cargo vendor --version to check version of cargo-vendor

NEW
Assigned to

Status

Firefox Build System
General
a year ago
5 months ago

People

(Reporter: xidorn, Assigned: xidorn)

Tracking

Trunk

Firefox Tracking Flags

(firefox57 wontfix)

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

a year ago
This flag was added in alexcrichton/cargo-vendor#37 (since 0.1.11).
Comment hidden (mozreview-request)

Comment 2

a year ago
mozreview-review
Comment on attachment 8891123 [details]
Bug 1385131 - Use --version for checking version of cargo-vendor.

https://reviewboard.mozilla.org/r/162306/#review172816

::: python/mozbuild/mozbuild/vendor_rust.py:45
(Diff revision 1)
>      def check_cargo_vendor_version(self, cargo):
>          '''
>          Ensure that cargo-vendor is new enough. cargo-vendor 0.1.11 and newer
>          strips out .orig and .rej files which we want.
>          '''
> -        for l in subprocess.check_output([cargo, 'install', '--list']).splitlines():
> +        out = subprocess.check_output([cargo, 'vendor', '--version']).splitlines()[0]

I don't think this will actually work properly. If `cargo-vendor` isn't installed, this will raise an exception and that's not handled anywhere.
Attachment #8891123 - Flags: review?(ted) → review-

Updated

10 months ago
status-firefox57: --- → wontfix

Updated

5 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.