1385147 - stylo: Upgrade bindgen to 0.29

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Description

[Xidorn Quan [:xidorn] UTC+10]

That requires changes to both Gecko and Servo side.

Comment 1

[Manish Goregaokar [:manishearth]]

These are the gecko-side bindings changes we needed

commit a9578df3449e3ee5dc41ffda50dd3f5c61acd1ba
Author: Manish Goregaokar <[e-mail]>
Date:   Mon Jul 24 16:20:06 2017 -0700

    Bindings fixups
    
    MozReview-Commit-ID: JqtcYd5wzrz

diff --git a/layout/style/ServoBindings.toml b/layout/style/ServoBindings.toml
index 0afb98d..1718403 100644
--- a/layout/style/ServoBindings.toml
+++ b/layout/style/ServoBindings.toml
@@ -121,6 +121,7 @@ whitelist-types = [
     "mozilla::ComputedTiming",
     "mozilla::ComputedTimingFunction",
     "mozilla::ComputedTimingFunction::BeforeFlag",
+    "mozilla::MallocSizeOf",
     "mozilla::ServoElementSnapshot.*",
     "mozilla::ServoStyleContext",
     "mozilla::ServoStyleSheetInner",
@@ -128,6 +129,8 @@ whitelist-types = [
     "mozilla::css::ErrorReporter",
     "mozilla::css::SheetParsingMode",
     "mozilla::css::URLMatchingFunction",
+    "mozilla::css::ImageValue",
+    "mozilla::css::LoaderReusableStyleSheets",
     "mozilla::dom::IterationCompositeOperation",
     "mozilla::dom::StyleChildrenIterator",
     "mozilla::HalfCorner",
@@ -169,6 +172,7 @@ whitelist-types = [
     "nsBorderColors",
     "nscolor",
     "nsChangeHint",
+    "nsCSSCounterDesc",
     "nsCSSCounterStyleRule",
     "nsCSSFontFaceRule",
     "nsCSSKeyword",
@@ -295,6 +299,7 @@ opaque-types = [
     "mozilla::detail::WeakReference",
     "mozilla::WeakPtr",
     "nsWritingIterator_reference", "nsReadingIterator_reference",
+    "nsBindingManager", # <- Causes missing derive(Debug) issues
     "nsTObserverArray",  # <- Inherits from nsAutoTObserverArray<T, 0>
     "nsTHashtable",  # <- Inheriting from inner typedefs that clang
                      #    doesn't expose properly.

The nsBindingManager stuff probably can be removed

Comment 2

[Xidorn Quan [:xidorn] UTC+10]

Only the whitelist ones are necessary now.

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=5ad8880acf45100cefbfbce5b26f9267e216a342

What's wrong with Windows build now...

Comment 3

[Manish Goregaokar [:manishearth]]

Oh I think it's permabusted on tip or on infra.

Comment 4

[Xidorn Quan [:xidorn] UTC+10]

OK I think the try push above is enough. The failing tasks are buildbot ones. All TC windows tasks work just fine.

Comment 5

[Xidorn Quan [:xidorn] UTC+10]

Attachment: Bug 1385147 - Upgrade to bindgen 0.29.

Review commit: https://reviewboard.mozilla.org/r/162376/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/162376/

Comment 6

[Cameron McCormack (:heycam)]

Comment on attachment 8891176 [details]
Bug 1385147 - Upgrade to bindgen 0.29.

https://reviewboard.mozilla.org/r/162376/#review167648

Comment 7

[Xidorn Quan [:xidorn] UTC+10]

Comment on attachment 8891176 [details]
Bug 1385147 - Upgrade to bindgen 0.29.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/162376/diff/1-2/

Comment 8

[Xidorn Quan [:xidorn] UTC+10]

Servo side: servo/servo#17902

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/eaaaa3adbe3c
Upgrade to bindgen 0.29. r=heycam

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/eaaaa3adbe3c

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ef19aed2b62b
followup - Mark mozilla::dom::OwningNodeOrString_Value opaque.

Comment 12

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/ef19aed2b62b