Closed
Bug 1385147
Opened 7 years ago
Closed 7 years ago
stylo: Upgrade bindgen to 0.29
Categories
(Core :: CSS Parsing and Computation, enhancement)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla56
Tracking | Status | |
---|---|---|
firefox56 | --- | fixed |
People
(Reporter: xidorn, Assigned: xidorn)
References
Details
Attachments
(1 file)
That requires changes to both Gecko and Servo side.
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → xidorn+moz
Comment 1•7 years ago
|
||
These are the gecko-side bindings changes we needed commit a9578df3449e3ee5dc41ffda50dd3f5c61acd1ba Author: Manish Goregaokar <manishearth@gmail.com> Date: Mon Jul 24 16:20:06 2017 -0700 Bindings fixups MozReview-Commit-ID: JqtcYd5wzrz diff --git a/layout/style/ServoBindings.toml b/layout/style/ServoBindings.toml index 0afb98d..1718403 100644 --- a/layout/style/ServoBindings.toml +++ b/layout/style/ServoBindings.toml @@ -121,6 +121,7 @@ whitelist-types = [ "mozilla::ComputedTiming", "mozilla::ComputedTimingFunction", "mozilla::ComputedTimingFunction::BeforeFlag", + "mozilla::MallocSizeOf", "mozilla::ServoElementSnapshot.*", "mozilla::ServoStyleContext", "mozilla::ServoStyleSheetInner", @@ -128,6 +129,8 @@ whitelist-types = [ "mozilla::css::ErrorReporter", "mozilla::css::SheetParsingMode", "mozilla::css::URLMatchingFunction", + "mozilla::css::ImageValue", + "mozilla::css::LoaderReusableStyleSheets", "mozilla::dom::IterationCompositeOperation", "mozilla::dom::StyleChildrenIterator", "mozilla::HalfCorner", @@ -169,6 +172,7 @@ whitelist-types = [ "nsBorderColors", "nscolor", "nsChangeHint", + "nsCSSCounterDesc", "nsCSSCounterStyleRule", "nsCSSFontFaceRule", "nsCSSKeyword", @@ -295,6 +299,7 @@ opaque-types = [ "mozilla::detail::WeakReference", "mozilla::WeakPtr", "nsWritingIterator_reference", "nsReadingIterator_reference", + "nsBindingManager", # <- Causes missing derive(Debug) issues "nsTObserverArray", # <- Inherits from nsAutoTObserverArray<T, 0> "nsTHashtable", # <- Inheriting from inner typedefs that clang # doesn't expose properly. The nsBindingManager stuff probably can be removed
Assignee | ||
Comment 2•7 years ago
|
||
Only the whitelist ones are necessary now. Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=5ad8880acf45100cefbfbce5b26f9267e216a342 What's wrong with Windows build now...
Comment 3•7 years ago
|
||
Oh I think it's permabusted on tip or on infra.
Assignee | ||
Comment 4•7 years ago
|
||
OK I think the try push above is enough. The failing tasks are buildbot ones. All TC windows tasks work just fine.
Comment hidden (mozreview-request) |
Comment 6•7 years ago
|
||
mozreview-review |
Comment on attachment 8891176 [details] Bug 1385147 - Upgrade to bindgen 0.29. https://reviewboard.mozilla.org/r/162376/#review167648
Attachment #8891176 -
Flags: review?(cam) → review+
Comment hidden (mozreview-request) |
Assignee | ||
Comment 8•7 years ago
|
||
Servo side: servo/servo#17902
Pushed by xquan@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/eaaaa3adbe3c Upgrade to bindgen 0.29. r=heycam
Comment 10•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/eaaaa3adbe3c
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Comment 11•7 years ago
|
||
Pushed by xquan@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ef19aed2b62b followup - Mark mozilla::dom::OwningNodeOrString_Value opaque.
Comment 12•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/ef19aed2b62b
You need to log in
before you can comment on or make changes to this bug.
Description
•