clang-format isn't catching * placement rules

RESOLVED INVALID

Status

NSS
Build
RESOLVED INVALID
7 months ago
7 months ago

People

(Reporter: mt, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

7 months ago
It's either the version of clang-format we use or the clang-format rules, but these don't detect and fix * placement problems.

That is,

static SECStatus
ssl_SomeFunction(sslSocket *ss)

is the right placement for C code and

bool SomeFunction(PRFileDesc* fd)

is the right placement for code in the gtests (we use Google style there).

We should tweak the clang-format rules so that this gets fixed.  If that means bumping the version, that's a bigger project, but still worth doing (we don't want to be stuck on 3.9 forever).
(Reporter)

Comment 1

7 months ago
Seems like the google style includes this and this isn't an issue.
Status: NEW → RESOLVED
Last Resolved: 7 months ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.