1385155 - Move MP4Stream into ContainerParser.cpp

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement, P3)

Description

[JW Wang [:jwwang] [:jw_wang]]

ContainerParser.cpp is the only user of MP4Stream. This is required to progress bug 1384872.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1385155. P1 - remove dead code.

We are able to remove some dead code for BlockingReadIntoCache,
LastReadFailed, ClearFailedRead, Pin and Unpin have no callers at all.

Review commit: https://reviewboard.mozilla.org/r/162352/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/162352/

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1385155. P2 - move MP4Stream into ContainerParser.cpp which is the only user.

Review commit: https://reviewboard.mozilla.org/r/162354/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/162354/

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1385155. P3 - let MP4Stream use SourceBufferResource instead of MediaResourceIndex.

Review commit: https://reviewboard.mozilla.org/r/162356/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/162356/

Comment 4

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8891161 [details]
Bug 1385155. P1 - remove dead code.

https://reviewboard.mozilla.org/r/162352/#review167618

Comment 5

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8891162 [details]
Bug 1385155. P2 - move MP4Stream into ContainerParser.cpp which is the only user.

https://reviewboard.mozilla.org/r/162354/#review167620

Comment 6

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8891163 [details]
Bug 1385155. P3 - let MP4Stream use SourceBufferResource instead of MediaResourceIndex.

https://reviewboard.mozilla.org/r/162356/#review167624

Nice one!

Comment 7

[JW Wang [:jwwang] [:jw_wang]]

Thanks!

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/343e5952d6fe
P1 - remove dead code. r=gerald
https://hg.mozilla.org/integration/autoland/rev/78d726cefb12
P2 - move MP4Stream into ContainerParser.cpp which is the only user. r=gerald
https://hg.mozilla.org/integration/autoland/rev/e264858a00d4
P3 - let MP4Stream use SourceBufferResource instead of MediaResourceIndex. r=gerald

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/343e5952d6fe
https://hg.mozilla.org/mozilla-central/rev/78d726cefb12
https://hg.mozilla.org/mozilla-central/rev/e264858a00d4