Closed Bug 1385155 Opened 2 years ago Closed 2 years ago

Move MP4Stream into ContainerParser.cpp

Categories

(Core :: Audio/Video: Playback, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla56
Tracking Status
firefox56 --- fixed

People

(Reporter: jwwang, Assigned: jwwang)

References

Details

Attachments

(3 files)

ContainerParser.cpp is the only user of MP4Stream. This is required to progress bug 1384872.
Assignee: nobody → jwwang
Blocks: 1384872
Priority: -- → P3
Attachment #8891161 - Flags: review?(gsquelart)
Attachment #8891162 - Flags: review?(gsquelart)
Attachment #8891163 - Flags: review?(gsquelart)
Comment on attachment 8891161 [details]
Bug 1385155. P1 - remove dead code.

https://reviewboard.mozilla.org/r/162352/#review167618
Attachment #8891161 - Flags: review?(gsquelart) → review+
Comment on attachment 8891162 [details]
Bug 1385155. P2 - move MP4Stream into ContainerParser.cpp which is the only user.

https://reviewboard.mozilla.org/r/162354/#review167620
Attachment #8891162 - Flags: review?(gsquelart) → review+
Comment on attachment 8891163 [details]
Bug 1385155. P3 - let MP4Stream use SourceBufferResource instead of MediaResourceIndex.

https://reviewboard.mozilla.org/r/162356/#review167624

Nice one!
Attachment #8891163 - Flags: review?(gsquelart) → review+
Thanks!
Pushed by jwwang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/343e5952d6fe
P1 - remove dead code. r=gerald
https://hg.mozilla.org/integration/autoland/rev/78d726cefb12
P2 - move MP4Stream into ContainerParser.cpp which is the only user. r=gerald
https://hg.mozilla.org/integration/autoland/rev/e264858a00d4
P3 - let MP4Stream use SourceBufferResource instead of MediaResourceIndex. r=gerald
You need to log in before you can comment on or make changes to this bug.