Closed
Bug 1385155
Opened 7 years ago
Closed 7 years ago
Move MP4Stream into ContainerParser.cpp
Categories
(Core :: Audio/Video: Playback, enhancement, P3)
Core
Audio/Video: Playback
Tracking
()
RESOLVED
FIXED
mozilla56
Tracking | Status | |
---|---|---|
firefox56 | --- | fixed |
People
(Reporter: jwwang, Assigned: jwwang)
References
Details
Attachments
(3 files)
ContainerParser.cpp is the only user of MP4Stream. This is required to progress bug 1384872.
Assignee | ||
Updated•7 years ago
|
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Attachment #8891161 -
Flags: review?(gsquelart)
Attachment #8891162 -
Flags: review?(gsquelart)
Attachment #8891163 -
Flags: review?(gsquelart)
Comment 4•7 years ago
|
||
mozreview-review |
Comment on attachment 8891161 [details] Bug 1385155. P1 - remove dead code. https://reviewboard.mozilla.org/r/162352/#review167618
Attachment #8891161 -
Flags: review?(gsquelart) → review+
Comment 5•7 years ago
|
||
mozreview-review |
Comment on attachment 8891162 [details] Bug 1385155. P2 - move MP4Stream into ContainerParser.cpp which is the only user. https://reviewboard.mozilla.org/r/162354/#review167620
Attachment #8891162 -
Flags: review?(gsquelart) → review+
Comment 6•7 years ago
|
||
mozreview-review |
Comment on attachment 8891163 [details] Bug 1385155. P3 - let MP4Stream use SourceBufferResource instead of MediaResourceIndex. https://reviewboard.mozilla.org/r/162356/#review167624 Nice one!
Attachment #8891163 -
Flags: review?(gsquelart) → review+
Assignee | ||
Comment 7•7 years ago
|
||
Thanks!
Pushed by jwwang@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/343e5952d6fe P1 - remove dead code. r=gerald https://hg.mozilla.org/integration/autoland/rev/78d726cefb12 P2 - move MP4Stream into ContainerParser.cpp which is the only user. r=gerald https://hg.mozilla.org/integration/autoland/rev/e264858a00d4 P3 - let MP4Stream use SourceBufferResource instead of MediaResourceIndex. r=gerald
Comment 9•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/343e5952d6fe https://hg.mozilla.org/mozilla-central/rev/78d726cefb12 https://hg.mozilla.org/mozilla-central/rev/e264858a00d4
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in
before you can comment on or make changes to this bug.
Description
•