Closed Bug 1385178 Opened 7 years ago Closed 7 years ago

Decoded data allocation in SyncLoadFontData shouldn't be infallible

Categories

(Core :: Layout, enhancement)

Product:
Core
Component:
Layout
Version:
53 Branch
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla57
Tracking Flags:
Tracking Status
firefox57 --- fixed

People

(Reporter: bzbarsky, Assigned: bzbarsky)

Details

Attachments

(1 file)

Do fallible allocation of our font data buffer in SyncLoadFontData
1.09 KB, patch
jfkthame
: review+
Details | Diff | Splinter Review 
It's using moz_xmalloc, then null-checking.  But moz_xmalloc is infallible.

Looks like that was put in place instead of the NS_Alloc that used to be there, and which presumably got made infallible at some point....

In any case, this allocation should clearly be fallible: it's a big buffer being allocated.
Attachment #8891464 - Flags: review?(jfkthame) → review+
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/97fe9cf339fe
Do fallible allocation of our font data buffer in SyncLoadFontData.  r=jfkthame
https://hg.mozilla.org/mozilla-central/rev/97fe9cf339fe
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: