Closed Bug 1385191 Opened 2 years ago Closed 2 years ago

Prefer email address from the FxA profile over that from the account

Categories

(Firefox :: Firefox Accounts, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
Firefox 56
Tracking Status
firefox56 --- fixed

People

(Reporter: markh, Assigned: markh)

References

Details

Attachments

(1 file)

In bug 1383663 we want to handle the fact a user's email address might change. Doing that correctly is not completely trivial, but a small step we could take in the meantime is to prefer the email address from the profile over what we have stored for the account. It will mean that a user may briefly see the email address flip from the old to the new, but this seems better than forever showing old.
Ed, I'm about to put a patch up - if you think it's OK, please go ahead and land it so it makes the merge (but no big deal if you have concerns - it can wait)
Assignee: nobody → markh
Comment on attachment 8891202 [details]
Bug 1385191 - Prefer email address from the FxA profile over that from the account.

https://reviewboard.mozilla.org/r/162424/#review167796

This looks fine to me, thanks.
Attachment #8891202 - Flags: review?(eoger) → review+
Pushed by eoger@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e9bb73e285c4
Prefer email address from the FxA profile over that from the account. r=eoger
https://hg.mozilla.org/mozilla-central/rev/e9bb73e285c4
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Product: Core → Firefox
Target Milestone: mozilla56 → Firefox 56
You need to log in before you can comment on or make changes to this bug.