Closed Bug 1385194 Opened 5 years ago Closed 5 years ago
HTML5 notification permission request is not shown when HTML page is opened from Firefox add-on
User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/59.0.3071.115 Safari/537.36 Steps to reproduce: Hi, There is a problem with HTML5 notification permission request in Firefox 55.0b12. It's not shown (or blinking) when HTML page which asks for notification permission is run inside 'popup' window opened from Firefox add-on. I've created a simple Firefox add-on which creates popup window and navigates to http://www.bennish.net/web-notifications.html web page. This page checks HTML5 notification site capability. Notification permission request show should appear once you press 'Authorize' button. Note: 1. The problem is not reproduced in Firefox 54 2. The same problem exists in Firefox Nightly version 3. To reproduce the problem please make sure that you've cleared Site Preferences. 4. Password save dialog is not shown as well. Steps to reproduce: 1. Unzip firefox_notifications.zip (attached) to some folder 2. Go to Beta Firefox and navigate to about:debugging 3. Click on "Load Temporary Add-On" button and select any file from the folder 4. Press on cogwheel button located in Firefox toolbar. 5. Press 'Authorize' button. Actual results: HTML5 Notification permission request is shown Expected results: HTML5 Notification permission request is shown
Component: Untriaged → WebExtensions: General
Product: Firefox → Toolkit
[Tracking Requested - why for this release]: WebExtensions regression Regression window: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=e3a6a933eee5107d2605e9f9f0b1695fa924f58a&tochange=cb6056e7c4907996a31ec6b4a7d0bdccf7611ff3 Suspect: Bug 1377802 - Permission prompt remains open after page navigation :johannh, Your patch seems to cause the problem. Could you look this?
Ugh, why is this window fully chromeless? I didn't even know we were supporting windows without a nav-bar anywhere. How do you verify the site identity? The correct solution, IMO, is to give this window a nav bar. I'm not sure I want to pick this fight right now, though. We should probably just let the code we have for DOM fullscreen apply for chromeless popups as well. :/ I'm a bit concerned about a lack of security indicators, for example for showing camera or microphone access. Thanks for reporting this, anyway!
Assignee: nobody → jhofmann
Status: NEW → ASSIGNED
Component: WebExtensions: General → Site Identity and Permission Panels
Flags: needinfo?(jhofmann) → qe-verify+
Priority: -- → P1
Product: Toolkit → Firefox
Comment on attachment 8891636 [details] Bug 1385194 - Make PopupNotifications handle windows without a location bar or a tab bar. https://reviewboard.mozilla.org/r/162734/#review168756 Looks good, thanks for the fix!
Attachment #8891636 - Flags: review?(paolo.mozmail) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/b6a01f3ac704 Make PopupNotifications handle windows without a location bar or a tab bar. r=Paolo
I have reproduced this Bug with Beta 55.0b12 (2017-07-24) on Windows 10, 64 Bit! The bug's fix is now verified on latest Beta 56.0b9 Build ID 20170903140023 User Agent Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:56.0) Gecko/20100101 Firefox/56.0
QA Whiteboard: [testday-20170901]
I have reproduced this Bug with Nightly Beta 55.0b12 (2017-07-24) on Ubuntu 16.04 LTS! The bug's fix is now verified on latest Beta! Build ID 20170911193316 User Agent Mozilla/5.0 (X11; Linux x86_64; rv:56.0) Gecko/20100101 Firefox/56.0 [bugday-20170913]
As per Comment 9 & Comment 10, I am marking this bug as verified fixed.
Can you file a followup bug for webextensions to not do this? I don't think we should be allowing extensions to create windows without location bars.
(In reply to :Gijs from comment #12) > Can you file a followup bug for webextensions to not do this? I don't think > we should be allowing extensions to create windows without location bars. Filed bug 1400252, thanks for the reminder.
You need to log in before you can comment on or make changes to this bug.