Closed
Bug 1385197
Opened 7 years ago
Closed 7 years ago
Clarify the how and why of JS line number getting in AddPseudoEntry
Categories
(Core :: Gecko Profiler, enhancement)
Core
Gecko Profiler
Tracking
()
RESOLVED
FIXED
mozilla57
| Tracking | Status | |
|---|---|---|
| firefox57 | --- | fixed |
People
(Reporter: n.nethercote, Assigned: n.nethercote)
References
Details
Attachments
(1 file)
|
3.37 KB,
patch
|
mstange
:
review+
|
Details | Diff | Splinter Review |
The new code preserves the existing behaviour, but it clearer, and gets rid of two XXX comments.
|
Assignee | |
Comment 1•7 years ago
|
||
Attachment #8891223 -
Flags: review?(mstange)
|
||
Comment 3•7 years ago
|
||
Comment on attachment 8891223 [details] [diff] [review] Clarify the how and why of JS line number getting in AddPseudoEntry Review of attachment 8891223 [details] [diff] [review]: ----------------------------------------------------------------- This makes a lot more sense.
Attachment #8891223 -
Flags: review?(mstange) → review+
|
|
Assignee | |
Comment 4•7 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/974bd1c1c1f6aa85178a13311fe88389f3a9187a Bug 1385197 - Clarify the how and why of JS line number getting in AddPseudoEntry. r=mstange.
|
||
Comment 5•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/974bd1c1c1f6
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in
before you can comment on or make changes to this bug.
Description
•