Need to update execution budget when background state changes

RESOLVED FIXED in Firefox 56

Status

()

enhancement
RESOLVED FIXED
2 years ago
a month ago

People

(Reporter: farre, Assigned: farre)

Tracking

unspecified
mozilla56
Points:
---

Firefox Tracking Flags

(firefox56 fixed)

Details

Attachments

(1 attachment, 2 obsolete attachments)

Comment hidden (empty)
(Assignee)

Updated

2 years ago
Assignee: nobody → afarre
Blocks: 1377766
(Assignee)

Comment 1

2 years ago
Don't really know what happened here, this is really important for budgeting throttling to work correctly.
Attachment #8891309 - Flags: review?(bkelly)
(Assignee)

Comment 2

2 years ago
Attachment #8891309 - Attachment is obsolete: true
Attachment #8891309 - Flags: review?(bkelly)
Attachment #8891314 - Flags: review?(bkelly)
Comment on attachment 8891314 [details] [diff] [review]
0001-Bug-1385238-Reset-execution-budget-when-background-s.patch

Review of attachment 8891314 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with comments addressed.

::: dom/base/TimeoutManager.cpp
@@ +1156,5 @@
>        MOZ_ALWAYS_SUCCEEDS(MaybeSchedule(nextTimeout->When()));
>      }
>    }
> +
> +  mExecutionBudget = GetMaxBudget(mWindow.IsBackgroundInternal());

Please move this to the top of the method.  Otherwise it won't be in effect when we call MaybeSchedule() when a window moves to the foreground.
Attachment #8891314 - Flags: review?(bkelly) → review+
(Assignee)

Comment 5

2 years ago
r+ carrying over from previous.
Attachment #8891314 - Attachment is obsolete: true
Attachment #8891414 - Flags: review+
(Assignee)

Updated

2 years ago
Keywords: checkin-needed

Comment 6

2 years ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/270ed5e9ce20
Reset execution budget when background state changes. r=bkelly
Keywords: checkin-needed

Comment 7

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/270ed5e9ce20
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Component: DOM → DOM: Core & HTML
Product: Core → Core
You need to log in before you can comment on or make changes to this bug.