1385238 - Need to update execution budget when background state changes

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Comment 1

[Andreas Farre [:farre]]

Attachment: 0001-Bug-1385238-Reset-execution-budget-when-background-s.patch

Don't really know what happened here, this is really important for budgeting throttling to work correctly.

Comment 2

[Andreas Farre [:farre]]

Attachment: 0001-Bug-1385238-Reset-execution-budget-when-background-s.patch

Comment 3

[Andreas Farre [:farre]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ff5a9da2df91f6dfa7af0947efac2876fdff0cc8&group_state=expanded

Comment 4

[Ben Kelly [:bkelly, not reviewing]]

Comment on attachment 8891314 [details] [diff] [review]
0001-Bug-1385238-Reset-execution-budget-when-background-s.patch

Review of attachment 8891314 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with comments addressed.

::: dom/base/TimeoutManager.cpp
@@ +1156,5 @@
>        MOZ_ALWAYS_SUCCEEDS(MaybeSchedule(nextTimeout->When()));
>      }
>    }
> +
> +  mExecutionBudget = GetMaxBudget(mWindow.IsBackgroundInternal());

Please move this to the top of the method.  Otherwise it won't be in effect when we call MaybeSchedule() when a window moves to the foreground.

Comment 5

[Andreas Farre [:farre]]

Attachment: 0001-Bug-1385238-Reset-execution-budget-when-background-s.patch

r+ carrying over from previous.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/270ed5e9ce20
Reset execution budget when background state changes. r=bkelly

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/270ed5e9ce20