Closed
Bug 1385238
Opened 7 years ago
Closed 7 years ago
Need to update execution budget when background state changes
Categories
(Core :: DOM: Core & HTML, enhancement)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla56
Tracking | Status | |
---|---|---|
firefox56 | --- | fixed |
People
(Reporter: farre, Assigned: farre)
References
Details
Attachments
(1 file, 2 obsolete files)
3.47 KB,
patch
|
farre
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•7 years ago
|
||
Don't really know what happened here, this is really important for budgeting throttling to work correctly.
Attachment #8891309 -
Flags: review?(bkelly)
Assignee | ||
Comment 2•7 years ago
|
||
Attachment #8891309 -
Attachment is obsolete: true
Attachment #8891309 -
Flags: review?(bkelly)
Attachment #8891314 -
Flags: review?(bkelly)
Assignee | ||
Comment 3•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=ff5a9da2df91f6dfa7af0947efac2876fdff0cc8&group_state=expanded
Comment 4•7 years ago
|
||
Comment on attachment 8891314 [details] [diff] [review] 0001-Bug-1385238-Reset-execution-budget-when-background-s.patch Review of attachment 8891314 [details] [diff] [review]: ----------------------------------------------------------------- r=me with comments addressed. ::: dom/base/TimeoutManager.cpp @@ +1156,5 @@ > MOZ_ALWAYS_SUCCEEDS(MaybeSchedule(nextTimeout->When())); > } > } > + > + mExecutionBudget = GetMaxBudget(mWindow.IsBackgroundInternal()); Please move this to the top of the method. Otherwise it won't be in effect when we call MaybeSchedule() when a window moves to the foreground.
Attachment #8891314 -
Flags: review?(bkelly) → review+
Assignee | ||
Comment 5•7 years ago
|
||
r+ carrying over from previous.
Attachment #8891314 -
Attachment is obsolete: true
Attachment #8891414 -
Flags: review+
Assignee | ||
Updated•7 years ago
|
Keywords: checkin-needed
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/270ed5e9ce20 Reset execution budget when background state changes. r=bkelly
Keywords: checkin-needed
Comment 7•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/270ed5e9ce20
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•