1385247 - Hamburger menu is wrongly displayed if the FF window is moved in the middle of the screen

Status: RESOLVED WORKSFORME

(Firefox :: Toolbars and Customization, defect, P3)

Description

[Mihai Boldan, QA [:mboldan]]

[Affected versions]:
- Firefox 55.0b13, Firefox 56.0a1 (2017-07-27)
 
[Affected platforms]:
- Windows 10x64, Mac OS X 10.11

[Steps to reproduce]:
1. Launch Firefox. 
2. Go to Customization mode and add a large no. of buttons in the hamburger menu.
3. Exit Customization mode.
4. Reduce browser height and position so the hamburger menu dropdown will be overflowed.
5. Move the FF window in the middle of the screen.
6. Open Hamburger menu.

[Expected result]:
- The hamburger menu is correctly displayed above or inside FF window.

[Actual result]:
- The hamburger menu is first displayed above the hamburger menu button and than under the button. See https://drive.google.com/open?id=0B-cUbHVNThEKc2d4WGJGTFJGYm8 .

[Regression range]:
- I will search for the regression asap.

[Additional notes]:
- On latest Nightly, the issue is reproducible only with the browser.photon.structure.enabled pref set to false. 
- I was not able to reproduce the issue on Ubuntu 16.04x64.
- Also the issue is not reproducible with the default hamburger menu.

Comment 1

[:Gijs (he/him)]

Does this still reproduce after bug 1384899?

I doubt that this is serious enough to warrant a last-minute fix for 56 because it only happens if you add more items to the customize mode panel, and you have the window squarely in the middle of the screen, and it's only the animation that breaks, the menu is functional... but I guess it would at least be good to know if this is going to affect 56 release or not.

Comment 2

[:Gijs (he/him)]

p3 for 57, we could reconsider for 56 if this is still an issue and we think it's serious enough. Alternatively, we could mark wontfix if we're not interested in fixing this in 56.

Comment 3

[:Gijs (he/him)]

(In reply to :Gijs from comment #1)
> I doubt that this is serious enough to warrant a last-minute fix for 56
> because it only happens if you add more items to the customize mode panel,
> and you have the window squarely in the middle of the screen, and it's only
> the animation that breaks, the menu is functional... but I guess it would at
> least be good to know if this is going to affect 56 release or not.

Ni :dolske to check that this is a reasonable assessment for 56.

Comment 4

[Mihai Boldan, QA [:mboldan]]

(In reply to :Gijs from comment #1)
> Does this still reproduce after bug 1384899?
> 
> I doubt that this is serious enough to warrant a last-minute fix for 56
> because it only happens if you add more items to the customize mode panel,
> and you have the window squarely in the middle of the screen, and it's only
> the animation that breaks, the menu is functional... but I guess it would at
> least be good to know if this is going to affect 56 release or not.

This issue is still reproducible on Firefox 56.0b12, under Windows 10x64.
From a QE perspective, this issue is not severe enough to call for a last-minute fix for 56, since is kind of an edge case and the severity of this bug is minor.

Please let me know if you have any other concerns related to this issue.

Comment 5

[:Gijs (he/him)]

OK, going to mark wontfix for 56 and resolve wfm given that it works on 57 with the photon hamburger panel. Leaving ni in case dolske thinks we should reconsider.

Comment 6

[Justin Dolske [:Dolske]]

SGTM.