Closed Bug 1385276 Opened 3 years ago Closed 3 years ago

move PROFILE_*FLAGS to moz.configure

Categories

(Firefox Build System :: General, enhancement)

enhancement
Not set

Tracking

(firefox57 fixed)

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- fixed

People

(Reporter: froydnj, Assigned: froydnj)

Details

Attachments

(1 file)

We are guaranteed to use a GCC or clang new enough that we don't have to
bother checking whether the flags are supported or not.
It's nice to get rid of all this stuff in old-configure.
Attachment #8891346 - Flags: review?(mshal)
Comment on attachment 8891346 [details] [diff] [review]
move PROFILE_*FLAGS to moz.configure

Looks good to me!

>-if test -z "$SKIP_COMPILER_CHECKS"; then

If you land this before the -pipe change, we'll need to keep this block intact until that lands.
Attachment #8891346 - Flags: review?(mshal) → review+
Pushed by nfroyd@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5f31bb248554
move PROFILE_*FLAGS to moz.configure; r=mshal
https://hg.mozilla.org/mozilla-central/rev/5f31bb248554
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.