1385278 - Move some functions in CacheIR from Ion

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, enhancement)

Description

[Tom S [:evilpie]]

Attachment: Move IsCacheable to CacheIR from Ion

The old IonCaches are gone, so we can move some of those functions into CacheIR.cpp

Comment 1

[Jan de Mooij [:jandem]]

Comment on attachment 8891349 [details] [diff] [review]
Move IsCacheable to CacheIR from Ion

Review of attachment 8891349 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for doing this. We've come a long way :)

(See also bug 1340153.)

::: js/src/jit/CacheIR.cpp
@@ +300,5 @@
>  }
>  
> +// Note: This differs from IsCacheableProtoChain in BaselineIC.cpp in that
> +// Ion caches can deal with objects on the proto chain that have uncacheable
> +// prototypes.

Please remove this comment, there's no longer an IsCacheableProtoChain in BaselineIC.cpp \o/

@@ +361,5 @@
> +    // instead of the WindowProxy.
> +    return !IsWindow(obj);
> +}
> +
> +bool

Nit: static bool

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/06c9ca99d461
Move IsCacheable* functions to CacheIR from Ion. r=jandem

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/06c9ca99d461

Comment 4

[Tom S [:evilpie]]

Attachment: Move StoreDenseElement to CacheIR from Ion

Comment 5

[Jan de Mooij [:jandem]]

Comment on attachment 8901990 [details] [diff] [review]
Move StoreDenseElement to CacheIR from Ion

Review of attachment 8901990 [details] [diff] [review]:
-----------------------------------------------------------------

\o/

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/35a1fe8f201b
Move StoreDenseElement to CacheIR from Ion. r=jandem

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/35a1fe8f201b

Comment 8

[Tom S [:evilpie]]

Attachment: Move GetReturnAddress into IonCacheIRCompiler

Almost done \o/. CodeLocationJump::repoint, CodeLocationLabel::repoint and CodeOffsetJump::fixup should probably be moved to a new Assembler-shared.cpp file.

Comment 9

[Jan de Mooij [:jandem]]

Comment on attachment 8905628 [details] [diff] [review]
Move GetReturnAddress into IonCacheIRCompiler

Review of attachment 8905628 [details] [diff] [review]:
-----------------------------------------------------------------

Nice! 

Moving the remaining functions to MacroAssembler.cpp or Assembler-shared.cpp SGTM.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ec521bf6357c
Move GetReturnAddress into IonCacheIRCompiler. r=jandem

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/ec521bf6357c

Comment 12

[Tom S [:evilpie]]

Attachment: Move the rest of IonCaches.h to Assembler-shared.h

Not sure yet if this is going to compile everywhere: https://treeherder.mozilla.org/#/jobs?repo=try&revision=e0673cd3449e7645d7b62f9eba2e3f70245ccfc0

Comment 13

[Tom S [:evilpie]]

Attachment: Move the rest of IonCaches.h to Assembler-shared.h

Looking pretty good in this new push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=b4fd7bfed3b950e358b13d7e69f56afa2e0a6c09

Comment 14

[Jan de Mooij [:jandem]]

Comment on attachment 8906273 [details] [diff] [review]
Move the rest of IonCaches.h to Assembler-shared.h

Review of attachment 8906273 [details] [diff] [review]:
-----------------------------------------------------------------

Sweet!

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ea4ebbcd0022
Move the rest of IonCaches.h to Assembler-shared.h. r=jandem

Comment 16

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/ea4ebbcd0022