1385296 - Improve GC profile and stats output

Status: RESOLVED FIXED

(Core :: JavaScript: GC, enhancement)

Description

[Jon Coppeard (:jonco)]

Attachment: improve-profile

Here's a patch that makes a bunch of small improvements to JS_GC_PROFILE / MOZ_GCTIMER output:

 - adds slice budget to the major GC profile
 - adds indicators for shrinking, reset and non-incremental GCs
 - refactors the profile times to be just the major top-level phases
 - fixes printing of profile headers for the nursery
 - fixes indentation of MOZ_GCTIMER stats output
 - removes phases that display as taking zero time

Comment 1

[Steve Fink [:sfink] [:s:]]

Comment on attachment 8891356 [details] [diff] [review]
improve-profile

Review of attachment 8891356 [details] [diff] [review]:
-----------------------------------------------------------------

Cool. I confess I've only really been looking at the stats by extracting them from profiles, so I haven't been paying any attention to the MOZ_GCTIMER output. But it's important, especially since it's the easiest to use.

::: js/src/gc/Statistics.cpp
@@ +462,5 @@
>      return DuplicateString(buffer);
>  }
>  
> +static bool
> +IncludePhase(TimeDuration duration)

The naming is a little odd. The decision of whether to include the phase belongs to the caller; I'd expect "SignificantDuration" or "NontrivialPhase" or something. But... meh. Doesn't matter.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9236439b1cd4
Improve JS_GC_PROFILE / MOZ_GCTIMER output r=sfink

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/9236439b1cd4