Closed Bug 1385298 Opened 2 years ago Closed 2 years ago

Intermittent dom/base/crashtests/504224.html | load failed: timed out waiting for reftest-wait to be removed

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox58 --- fixed
firefox59 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: mayhemer)

References

Details

(Keywords: intermittent-failure, Whiteboard: [stockwell fixed:other])

Attachments

(1 file)

Hi Bevis, I know this is not at your typical wheelhouse, but could you please help take a look first and suggest the next step? Thanks!
Flags: needinfo?(btseng)
Sure! Keep NI on me to follow-up!
Attached patch v1Splinter Review
The window.frames[0].location.reload() happens too soon - it just reloads the iframe on and on w/o a chance for it to load and get to the point when unload event can trigger, which can happen on any slower machine and specially on android and specially when we remove cache read/write concurrency of top level loads in bug 1340197.  

This test takes enormous amount of time even when passing, on most platforms - I've seem 2 to 3 minutes!

I rewrote it to make more sense and be stable and also pass way more quickly.  I also verified using [1] that it still crashes Firefox before bug 504224 fix.

Ben, you were on the list of suggested reviewers, feel free to bounce or forward at will, thanks.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f0411e42c5151025163b73ac1d6ce53b18a41c16

[1] http://ftp.mozilla.org/pub/firefox/nightly/2009/07/2009-07-25-04-mozilla-central/
Assignee: nobody → honzab.moz
Status: NEW → ASSIGNED
Attachment #8934325 - Flags: review?(bkelly)
Whiteboard: [stockwell needswork:owner] → [stockwell]
Blocks: 1340197
Flags: needinfo?(btseng)
Thanks for looking into this, Honza!
Comment on attachment 8934325 [details] [diff] [review]
v1

Review of attachment 8934325 [details] [diff] [review]:
-----------------------------------------------------------------

Seems reasonable.  Thank you for verifying that it still crashes before bug 504224 was fixed!
Attachment #8934325 - Flags: review?(bkelly) → review+
Thanks for a quick r+!
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bff73e215867
Fix test for bug 504224 to actually do something. r=bkelly
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/bff73e215867
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Whiteboard: [stockwell] → [stockwell fixed:other]
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.