Closed Bug 1385308 Opened 3 years ago Closed 3 years ago
Party Domain should be properly set for about:newtab
After giving Activity Stream URI_SAFE_FOR_UNTRUSTED_CONTENT in Bug 1021667, we were forced to exempt about:newtab from the test browser_firstPartyIsolation_aboutPages.js since it was failing with the following error: 69 INFO loading page about:newtab, origin is about:newtab 70 INFO principal [xpconnect wrapped (nsISupports, nsIPrincipal, nsISerializable)] Buffered messages finished 71 INFO TEST-UNEXPECTED-FAIL | browser/components/originattributes/test/browser/browser_firstPartyIsolation_aboutPages.js | The about page should have firstPartyDomain set - "" == "about.ef2a7dd5-93bc-417f-a698-142c3116864f.mozilla" - We should figure out how to properly set the firstPartyDomain for about:newtab, or at least figure why the test is failing when we set the URI_SAFE_FOR_UNTRUSTED_CONTENT flag in the first place.
Assignee: nobody → allstars.chh
Status: NEW → ASSIGNED
fixed eslint error.
Comment on attachment 8896123 [details] [diff] [review] Patch. >+ * In tabbrowser.addTab, when it finds out the uri is about:newtab, it will use >+ * the preloaded browser, which won't have the pref privact.firstpartyt.isolate privacy.firstparty. >+ * set. >+ * >+ * To prevent to use the preloaded browser, a simple trick is open a window >+ * first. >+ */ But doesn't this mean about:newtab doesn't use firstparty.isolate normally? Isn't there inconsistency that some times pref is set but not always? Or am I missing something here. Please clarify and ask review again, or fix preloaded browser to have the pref too
Comment on attachment 8896906 [details] [diff] [review] Patch. v2 Review of attachment 8896906 [details] [diff] [review]: ----------------------------------------------------------------- Hi smaug Because the preloaded browser might cause some misunderstanding, I rewrote the patch with disable preloading browser when the pref 'privacy.firstparty,isolate' is on. (See commit message for explanation) Could you help to review this again? Thanks
But why preloading browser works differently? That is really worrisome.
Comment on attachment 8896906 [details] [diff] [review] Patch. v2 oh, oh, now I see. I guess the previous patch is ok after all. Sorry, I somehow missed the issue.
Pushed by email@example.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/2cc320aac603 Test about:newtab should have firstPartyDomain. r=smaug
Attachment #8896906 - Attachment is obsolete: true
Component: Activity Streams: Newtab → New Tab Page
You need to log in before you can comment on or make changes to this bug.