Closed
Bug 1385324
Opened 7 years ago
Closed 7 years ago
HTMLFormControlsCollection::GetSortedControls() is very malloc heavy
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla56
Tracking | Status | |
---|---|---|
firefox56 | --- | fixed |
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
(Blocks 1 open bug)
Details
Attachments
(2 files, 1 obsolete file)
1.74 KB,
patch
|
qdot
:
review+
|
Details | Diff | Splinter Review |
7.91 KB,
patch
|
qdot
:
review+
|
Details | Diff | Splinter Review |
See this profile: https://perfht.ml/2v6ntHb The nsTArray there needs to have some preallocated space.
Assignee | ||
Comment 1•7 years ago
|
||
Attachment #8891404 -
Flags: review?(kyle)
Assignee | ||
Comment 2•7 years ago
|
||
Attachment #8891405 -
Flags: review?(kyle)
Assignee | ||
Comment 3•7 years ago
|
||
Attachment #8891426 -
Flags: review?(kyle)
Assignee | ||
Updated•7 years ago
|
Attachment #8891405 -
Attachment is obsolete: true
Attachment #8891405 -
Flags: review?(kyle)
Updated•7 years ago
|
Attachment #8891404 -
Flags: review?(kyle) → review+
Updated•7 years ago
|
Attachment #8891426 -
Flags: review?(kyle) → review+
Pushed by eakhgari@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/485ceaeda922 Part 1: Use a preallocated buffer of 100 elements to try to avoid memory allocations in HTMLFormControlsCollection::GetSortedControls(); r=qdot https://hg.mozilla.org/integration/mozilla-inbound/rev/1ba4cfc4fa62 Part 2: Rewrite HTMLFormControlsCollection::GetSortedControls() to use RefPtr instead of raw pointers; r=qdot
Comment 5•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/485ceaeda922 https://hg.mozilla.org/mozilla-central/rev/1ba4cfc4fa62
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•