1385350 - Add a Search on the home of about:telemetry

Status: RESOLVED FIXED

(Toolkit :: Telemetry, enhancement, P1)

Description

[flyingrub]

This will allow to search in any subsection for data and display them.

Comment 1

[flyingrub]

Attachment: Bug 1385350 - Add a Search on the home of about:telemetry

This allow to search in any section for data.

Review commit: https://reviewboard.mozilla.org/r/166614/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/166614/

Comment 2

[Chris H-C :chutten]

Comment on attachment 8895421 [details]
Bug 1385350 - Add a Search on the home of about:telemetry

https://reviewboard.mozilla.org/r/166614/#review173572

Does this work well if the user changes pings while there is a search?

Comment 3

[flyingrub]

It's a work in progress for now but I think that it should work when changing ping. Also it will need some rebase as there will probably be merge conflict.

Comment 4

[flyingrub]

Comment on attachment 8895421 [details]
Bug 1385350 - Add a Search on the home of about:telemetry

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/166614/diff/1-2/

Comment 5

[flyingrub]

I rebased the commit on m-c. Also tested that it works well when changing ping :).

Comment 6

[flyingrub]

Comment on attachment 8895421 [details]
Bug 1385350 - Add a Search on the home of about:telemetry

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/166614/diff/2-3/

Comment 7

[Chris H-C :chutten]

Comment on attachment 8895421 [details]
Bug 1385350 - Add a Search on the home of about:telemetry

https://reviewboard.mozilla.org/r/166614/#review174924

::: toolkit/content/aboutTelemetry.js:1401
(Diff revision 3)
> +    }
> +    if (section.id === "home-section") {
> +      if (text !== "") {
> +        this.homeSearch(text);
> +      } else {
> +        this.resetHome();

The pattern in the other searches is to call filterElements with the text and, if it is empty, to not filter anything away.

Merge resetHome and homeSearch, resetting when text === "", and then search(...) should look very similar for each section.

Comment 8

[flyingrub]

Comment on attachment 8895421 [details]
Bug 1385350 - Add a Search on the home of about:telemetry

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/166614/diff/3-4/

Comment 9

[Chris H-C :chutten]

Comment on attachment 8895421 [details]
Bug 1385350 - Add a Search on the home of about:telemetry

https://reviewboard.mozilla.org/r/166614/#review175006

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b23df13c1e57
Add a Search on the home of about:telemetry r=chutten

Comment 11

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backed out for eslint failure in toolkit/content/aboutTelemetry.js (strings must use doublequotes):

https://hg.mozilla.org/integration/autoland/rev/507f3006ca28ca42a5787709ab155972b80a142a

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=b23df13c1e5744d6a3e12a0f3747854a04ec1c05&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=runnable&filter-resultStatus=usercancel
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=123955069&repo=autoland

TEST-UNEXPECTED-ERROR | /home/worker/checkouts/gecko/toolkit/content/aboutTelemetry.js:1394:81 | Strings must use doublequote. (quotes)
TEST-UNEXPECTED-ERROR | /home/worker/checkouts/gecko/toolkit/content/aboutTelemetry.js:1836:83 | Strings must use doublequote. (quotes)

Comment 12

[flyingrub]

Comment on attachment 8895421 [details]
Bug 1385350 - Add a Search on the home of about:telemetry

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/166614/diff/4-5/

Comment 13

[flyingrub]

fixed.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f17a2e7ae4e0
Add a Search on the home of about:telemetry r=chutten

Comment 15

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/f17a2e7ae4e0