Add a Search on the home of about:telemetry

RESOLVED FIXED in Firefox 57

Status

()

Toolkit
Telemetry
P1
normal
RESOLVED FIXED
6 months ago
5 months ago

People

(Reporter: flyingrub, Assigned: flyingrub)

Tracking

(Blocks: 1 bug)

unspecified
mozilla57
Other
iOS
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox57 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

6 months ago
This will allow to search in any subsection for data and display them.
(Assignee)

Updated

6 months ago
Assignee: nobody → flyinggrub
Priority: -- → P1
Blocks: 1384534
Component: Telemetry → Telemetry
Product: Firefox for iOS → Toolkit
Comment hidden (mozreview-request)
(Assignee)

Updated

5 months ago
Depends on: 1389165
Attachment #8895421 - Flags: review?(gfritzsche) → review?(chutten)

Comment 2

5 months ago
mozreview-review
Comment on attachment 8895421 [details]
Bug 1385350 - Add a Search on the home of about:telemetry

https://reviewboard.mozilla.org/r/166614/#review173572

Does this work well if the user changes pings while there is a search?
Attachment #8895421 - Flags: review?(chutten)
(Assignee)

Comment 3

5 months ago
It's a work in progress for now but I think that it should work when changing ping. Also it will need some rebase as there will probably be merge conflict.
Comment hidden (mozreview-request)
(Assignee)

Comment 5

5 months ago
I rebased the commit on m-c. Also tested that it works well when changing ping :).
Comment hidden (mozreview-request)

Comment 7

5 months ago
mozreview-review
Comment on attachment 8895421 [details]
Bug 1385350 - Add a Search on the home of about:telemetry

https://reviewboard.mozilla.org/r/166614/#review174924

::: toolkit/content/aboutTelemetry.js:1401
(Diff revision 3)
> +    }
> +    if (section.id === "home-section") {
> +      if (text !== "") {
> +        this.homeSearch(text);
> +      } else {
> +        this.resetHome();

The pattern in the other searches is to call filterElements with the text and, if it is empty, to not filter anything away.

Merge resetHome and homeSearch, resetting when text === "", and then search(...) should look very similar for each section.
Attachment #8895421 - Flags: review?(chutten) → review-
Comment hidden (mozreview-request)

Comment 9

5 months ago
mozreview-review
Comment on attachment 8895421 [details]
Bug 1385350 - Add a Search on the home of about:telemetry

https://reviewboard.mozilla.org/r/166614/#review175006
Attachment #8895421 - Flags: review?(chutten) → review+
(Assignee)

Updated

5 months ago
Keywords: checkin-needed

Comment 10

5 months ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/b23df13c1e57
Add a Search on the home of about:telemetry r=chutten
Keywords: checkin-needed
Backed out for eslint failure in toolkit/content/aboutTelemetry.js (strings must use doublequotes):

https://hg.mozilla.org/integration/autoland/rev/507f3006ca28ca42a5787709ab155972b80a142a

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=b23df13c1e5744d6a3e12a0f3747854a04ec1c05&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=runnable&filter-resultStatus=usercancel
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=123955069&repo=autoland

TEST-UNEXPECTED-ERROR | /home/worker/checkouts/gecko/toolkit/content/aboutTelemetry.js:1394:81 | Strings must use doublequote. (quotes)
TEST-UNEXPECTED-ERROR | /home/worker/checkouts/gecko/toolkit/content/aboutTelemetry.js:1836:83 | Strings must use doublequote. (quotes)
Flags: needinfo?(flyinggrub)
Comment hidden (mozreview-request)
(Assignee)

Comment 13

5 months ago
fixed.
Flags: needinfo?(flyinggrub)
Keywords: checkin-needed

Comment 14

5 months ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/f17a2e7ae4e0
Add a Search on the home of about:telemetry r=chutten
Keywords: checkin-needed

Comment 15

5 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/f17a2e7ae4e0
Status: NEW → RESOLVED
Last Resolved: 5 months ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.