Closed
Bug 1385357
Opened 7 years ago
Closed 7 years ago
Whitelist gopher in WebExtensions protocol handlers
Categories
(WebExtensions :: Untriaged, enhancement)
WebExtensions
Untriaged
Tracking
(firefox56 fixed)
RESOLVED
FIXED
mozilla56
Tracking | Status | |
---|---|---|
firefox56 | --- | fixed |
People
(Reporter: spectre, Assigned: spectre)
Details
(Keywords: dev-doc-complete)
Attachments
(1 file, 1 obsolete file)
1.18 KB,
patch
|
mixedpuppy
:
review+
|
Details | Diff | Splinter Review |
Needed to convert OverbiteFF to WebExtensions and equalizes its support with navigator.registerProtocolHandler (per bug 1310427).
Assignee | ||
Updated•7 years ago
|
Attachment #8891423 -
Flags: review?(mixedpuppy)
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → spectre
Updated•7 years ago
|
Attachment #8891423 -
Flags: review?(mixedpuppy) → review+
Updated•7 years ago
|
Keywords: checkin-needed,
dev-doc-needed
Assignee | ||
Comment 1•7 years ago
|
||
Whoops, forgot to rev the bug # in the patch.
Attachment #8891423 -
Attachment is obsolete: true
Attachment #8891427 -
Flags: review?(mixedpuppy)
Updated•7 years ago
|
Attachment #8891427 -
Flags: review?(mixedpuppy) → review+
Assignee | ||
Comment 2•7 years ago
|
||
Comment on attachment 8891427 [details] [diff] [review] whitelist Gopher to be consistent with registerProtocolHandler Thank you! Marking checkin needed.
Attachment #8891427 -
Flags: checkin?
Updated•7 years ago
|
Attachment #8891427 -
Flags: checkin?
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/7ec849c7dae9 Whitelist Gopher to be consistent with registerProtocolHandler. r=mixedpuppy
Keywords: checkin-needed
Comment 4•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/7ec849c7dae9
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Comment 5•7 years ago
|
||
Thank you so much, Cameron! Your contribution has been added to the add-ons recognition wiki: https://wiki.mozilla.org/Add-ons/Contribute/Recognition#July_2017
Comment 6•7 years ago
|
||
I've updated the docs for this: https://developer.mozilla.org/en-US/Add-ons/WebExtensions/manifest.json/protocol_handlers Marking as dev-doc-complete, but let me know if you need anything else.
Keywords: dev-doc-needed → dev-doc-complete
Updated•6 years ago
|
Product: Toolkit → WebExtensions
You need to log in
before you can comment on or make changes to this bug.
Description
•