1385388 - Compilation failure doesn't tell me the exact command that's failing

Status: RESOLVED INVALID

(Firefox Build System :: General, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

Attachment: Build output

Usually when the build fails it spits out the command that failed. However right now I'm getting a compilation failure on OS X and the build system isn't giving me exact command. This makes it hard to debug. I tried --verbose but that didn't help. See attached output.

Comment 1

[Mike Hommey [:glandium]]

Try -v instead of --verbose.

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Same result. I also tried `mach -v build -v`, the only difference there was mach printed the environment variables at the beginning.

Comment 3

[Kartikaya Gupta (email:[e-mail])]

FWIW, the command that was failing was sccache - see bug 1385386 comment 1. I discovered that by running `make` in $OBJDIR/gfx/vr/openvr/

Comment 4

[Mike Hommey [:glandium]]

Here's the problem:

 0:03.10 Adding client.mk options from /Users/kats/zspace/mozilla-wr/.mozconfig:
 0:03.10     MOZ_MAKE_FLAGS=-s -j4

Your mozconfig is shooting you in the foot by a) ignoring your -j1 and b) ignoring your -v by adding -s

Comment 5

[Gregory Szorc [:gps]]

We may want to nuke MOZ_MAKE_FLAGS from mozconfigs. Pretty much the only uses of it I see are for -s and -j. These both can be controlled via `mach build` arguments and 99% of the time the defaults (-j == #cores and -s) are what the user wants.

Comment 6

[Botond Ballo [:botond]]

(In reply to Gregory Szorc [:gps] from comment #5)
> 99% of the time the defaults (-j == #cores and -s) are
> what the user wants.

Not if you're using IceCC [1].

[1] https://github.com/icecc/icecream

Comment 7

[Gregory Szorc [:gps]]

I've said it before and I'll say it again: we need to make the build system icecc aware so this stuff "just works." That may be bug 1313519.

At some point, people running -j128 because icecc will start complaining because you launch 128 expensive local processes and DoS your machine. I'm kinda surprised all the Rust we're adding hasn't made this a problem yet...

Comment 8

[Mike Hommey [:glandium]]

> I'm kinda surprised all the Rust we're adding hasn't made this a problem yet...

We're fortunate that either cargo is not very good at parallelising, or the crate dependencies make massive parallelism impossible at the moment. (or both)

Comment 9

[Kartikaya Gupta (email:[e-mail])]

(In reply to Mike Hommey [:glandium] from comment #4)
> Your mozconfig is shooting you in the foot by a) ignoring your -j1 and b)
> ignoring your -v by adding -s

Whoops, sorry! I verified that removing the stuff from my mozconfig fixes both (a) and (b). The -v option does indeed report the compilation failure command.