Change CSS shapes highlighter marker appearance

VERIFIED FIXED in Firefox 58

Status

P3
enhancement
VERIFIED FIXED
2 years ago
9 months ago

People

(Reporter: mpark, Assigned: mpark)

Tracking

(Blocks: 1 bug)

unspecified
Firefox 58

Firefox Tracking Flags

(firefox58 verified, firefox62 verified)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
Bug to change the appearance of markers on the CSS shapes highlighter from large black dots to smaller blue and white circles.
Blocks: 1242029
Priority: -- → P3
Status: NEW → ASSIGNED
Comment hidden (mozreview-request)
Attachment #8891474 - Flags: review?(zer0) → review?(pbrosset)

Comment 2

2 years ago
mozreview-review
Comment on attachment 8891474 [details]
Bug 1385398 - Change the appearance of CSS shapes highlighter markers.

https://reviewboard.mozilla.org/r/162614/#review179912
Attachment #8891474 - Flags: review?(pbrosset) → review+

Comment 3

2 years ago
Pushed by gabriel.luong@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0b7dd5c229be
Change the appearance of CSS shapes highlighter markers. r=pbro
Sorry, this had to be backed out for failing xpcshell test devtools/server/tests/unit/test_shapes_highlighter_helpers.js:

https://hg.mozilla.org/integration/mozilla-inbound/rev/0c649d3ebf4faa275cab992ec5223cf1fa652aad

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=0b7dd5c229be66a584d67d6901fbb9990eb234fa&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=127398699&repo=mozilla-inbound

07:16:14     INFO -  TEST-PASS | devtools/server/tests/unit/test_shapes_highlighter_helpers.js | test_coord_to_percent - [test_coord_to_percent : 62] coordToPercent for zero value - 0 == 0
07:16:14     INFO -  TEST-PASS | devtools/server/tests/unit/test_shapes_highlighter_helpers.js | test_eval_calc_expression - [test_eval_calc_expression : 87] evalCalcExpression with one value - 50 == 50
07:16:14     INFO -  TEST-PASS | devtools/server/tests/unit/test_shapes_highlighter_helpers.js | test_eval_calc_expression - [test_eval_calc_expression : 87] evalCalcExpression with percent and px values - 60 == 60
07:16:14     INFO -  TEST-PASS | devtools/server/tests/unit/test_shapes_highlighter_helpers.js | test_eval_calc_expression - [test_eval_calc_expression : 87] evalCalcExpression with a zero value - 10 == 10
07:16:14     INFO -  TEST-PASS | devtools/server/tests/unit/test_shapes_highlighter_helpers.js | test_eval_calc_expression - [test_eval_calc_expression : 87] evalCalcExpression with a negative value - 30 == 30
07:16:14     INFO -  TEST-PASS | devtools/server/tests/unit/test_shapes_highlighter_helpers.js | test_shape_mode_to_css_property_name - [test_shape_mode_to_css_property_name : 103] shapeModeToCssPropertyName for clip-path - "clipPath" == "clipPath"
07:16:14     INFO -  TEST-PASS | devtools/server/tests/unit/test_shapes_highlighter_helpers.js | test_shape_mode_to_css_property_name - [test_shape_mode_to_css_property_name : 103] shapeModeToCssPropertyName for shape-outside - "shapeOutside" == "shapeOutside"
07:16:14  WARNING -  TEST-UNEXPECTED-FAIL | devtools/server/tests/unit/test_shapes_highlighter_helpers.js | test_get_circle_path - [test_get_circle_path : 127] getCirclePath with no resizing, no zoom, 1:1 ratio - "MNaN,100aNaN,NaN 0 1,0 NaN,0aNaN,NaN 0 1,0 NaN,0" == "M-10,0a10,10 0 1,0 20,0a10,10 0 1,0 -20,0"
07:16:14     INFO -  /Users/cltbld/tasks/task_1504187665/build/tests/xpcshell/tests/devtools/server/tests/unit/test_shapes_highlighter_helpers.js:test_get_circle_path:127
07:16:14     INFO -  /Users/cltbld/tasks/task_1504187665/build/tests/xpcshell/tests/devtools/server/tests/unit/test_shapes_highlighter_helpers.js:run_test:24
07:16:14     INFO -  /Users/cltbld/tasks/task_1504187665/build/tests/xpcshell/head.js:_execute_test:538
07:16:14     INFO -  -e:null:1

Please fix the issue and submit an updated patch. Thank you.
Flags: needinfo?(mikeparkms)
Severity: normal → enhancement
Comment hidden (mozreview-request)
(Assignee)

Updated

2 years ago
Flags: needinfo?(mpark)
(Assignee)

Updated

2 years ago
Keywords: checkin-needed

Comment 6

2 years ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/07e7579a07be
Change the appearance of CSS shapes highlighter markers. r=pbro
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/07e7579a07be
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox58: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58

Comment 8

10 months ago
Hi everyone, i have retested this issue on Windows 10 , Windows 7 , Mac OSx and Linux using the latest version of nightly 62.0a1 (2018-05-28) and i can Confirm it as Fixed.
I will mark it accordingly.
Status: RESOLVED → VERIFIED
status-firefox58: fixed → verified
status-firefox62: --- → verified

Updated

9 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.