1385403 - Turn on OOP extensions by default on Mac OS

Status: VERIFIED FIXED

(Core :: Graphics: Layers, defect, P3)

Comment 1

[Firefox Bug Husbandry Bot]

https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Move_fix-optionals

Comment 2

[Jim Mathies [:jimm]]

Hey Markus, I'd like to figure out where this OOP popups work for webextensions is. There's a belief that you're actively working on bug 1370885 for this. Is that the case? It's currently P5/unassigned so seems unlikely but wanted to ask.

Comment 3

[Markus Stange [:mstange]]

I was actively working on bug 1406531 for this shortly before Austin, but then I got side tracked. I'm planning to get back on it soon though, hopefully this week.
I'm not planning on working on bug 1370885 myself. That's a bug that will make panel opening faster but isn't strictly necessary to turn on OOP popups.

Comment 4

[Andy McKay]

As I remember, we were going to measure popup speed once bug 1406531 (which I assigned to you Markus) has landed and see if we needed bug 1370885.

Comment 5

[Jim Mathies [:jimm]]

(In reply to Andy McKay [:andym] from comment #4)
> As I remember, we were going to measure popup speed once bug 1406531 (which
> I assigned to you Markus) has landed and see if we needed bug 1370885.

My understanding as well, thanks.

Comment 6

[Jim Mathies [:jimm]]

Hey Markus, do you know which pref we flip here?

Comment 7

[Kris Maglione [:kmag]]

Attachment: Bug 1385403: Part 1 - Enable OOP extensions on OS-X for non-release users.

Review commit: https://reviewboard.mozilla.org/r/225894/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/225894/

Comment 8

[Andrew Swan [:aswan]]

Comment on attachment 8956947 [details]
Bug 1385403: Part 1 - Enable OOP extensions on OS-X for non-release users.

https://reviewboard.mozilla.org/r/225894/#review231760

woo!

Comment 9

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3514a63add088d6bd4ae05a0f80166ea2d8f2040
Bug 1385403: Part 1 - Enable OOP extensions on OS-X for non-release users. r=aswan

Comment 10

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/79044302abd1165ed375708201090281972d32d8
Bug 1385403: Follow-up: Fix preprocessor syntax error. r=bustage CLOSED TREE

Comment 11

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/3514a63add08
https://hg.mozilla.org/mozilla-central/rev/79044302abd1

Comment 12

[:shell escalante]

Hi Markus,
Hi Krupa, (I didn't know Victor or Marius' Bugzilla names)

Do you have any concerns about flipping the pref to enable OOP for Mac by default to ride to beta 61?  

I haven't heard any new items raised from Nightly of QA, so believe this is good to ask Kris to land for 61.

Comment 13

[Markus Stange [:mstange]]

I'm not aware of any problems either, from my side this is good to go.

Comment 14

[Kris Maglione [:kmag]]

Attachment: Bug 1385403: Turn on OOP extensions on OS-X release builds.

Review commit: https://reviewboard.mozilla.org/r/238628/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/238628/

Comment 15

[Andrew Swan [:aswan]]

Comment on attachment 8969795 [details]
Bug 1385403: Turn on OOP extensions on OS-X release builds.

https://reviewboard.mozilla.org/r/238628/#review244346

Comment 16

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d085dd9ad3b781adce59c380ca38cf2b88ffa589
Bug 1385403: Turn on OOP extensions on OS-X release builds. r=aswan DONTBUILD

Comment 17

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/d085dd9ad3b7

Comment 18

[marius.santa]

Attachment: oop on by default on mac.gif

Issue was reproduced on Firefox 60.0a1 (20180201100326).
Retested and verified in Firefox 61.0a1 (20180424100107) on Mac OS 10.13.3.

Comment 19

[Ryan VanderMeulen [:RyanVM]]

This feels worth a relnote to me.