Closed Bug 1385407 Opened 6 years ago Closed 6 years ago

Audit theme CSS for selectors that reference the #star-button since the hierarchy changed

Categories

(Firefox :: Theme, enhancement, P1)

Product:
Firefox
Component:
Theme
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 56
Iteration:
56.4 - Aug 1
Tracking Flags:
Tracking Status
firefox56 --- fixed

People

(Reporter: jaws, Assigned: jaws)

References

Details

(Whiteboard: [reserve-photon-animation])

Attachments

(1 file)

Bug 1385407 - Add an extra selector for the urlbar-icon within the star-button-box now that the urlbar-icon for the bookmark star isn't a direct child of urlbar-icons.
59 bytes, text/x-review-board-request
Gijs
: review+
Details 
#star-button got a parent #star-button-box in bug 1352063. This may have broken some CSS selectors that were looking for `#urlbar-icons > .urlbar-icon`, of which #star-button is a .urlbar-icon.

This was caught in bug 1374477 comment 124.
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Iteration: --- → 56.4 - Aug 1
Flags: qe-verify?
Priority: -- → P1
Whiteboard: [photon-animation][triage] → [reserve-photon-animation]
Comment on attachment 8892061 [details]
Bug 1385407 - Add an extra selector for the urlbar-icon within the star-button-box now that the urlbar-icon for the bookmark star isn't a direct child of urlbar-icons.

https://reviewboard.mozilla.org/r/163076/#review168346

rs=me
Attachment #8892061 - Flags: review?(gijskruitbosch+bugs) → review+
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5f2af8ad6139
Add an extra selector for the urlbar-icon within the star-button-box now that the urlbar-icon for the bookmark star isn't a direct child of urlbar-icons. r=Gijs
Backed out for failing browser_startup_images.js with: Loaded image chrome://browser/skin/bookmark-hollow.svg should have been shown:

https://hg.mozilla.org/integration/autoland/rev/9de78eb067cf3ba198352d55582b4643001d4931

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=5f2af8ad61397dfaa61ede3cc1334d85f9be057d&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=119625599&repo=autoland

should have been shown. - 
10:00:19     INFO - Stack trace:
10:00:19     INFO - chrome://mochitests/content/browser/browser/base/content/test/performance/browser_startup_images.js:null:216
Flags: needinfo?(jaws)
Flags: needinfo?(jaws)
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 4c79d91ebd12 -d c92dcf2ce236: rebasing 410713:4c79d91ebd12 "Bug 1385407 - Add an extra selector for the urlbar-icon within the star-button-box now that the urlbar-icon for the bookmark star isn't a direct child of urlbar-icons. r=Gijs" (tip)
merging browser/base/content/browser.css
merging browser/base/content/test/performance/browser_startup_images.js
warning: conflicts while merging browser/base/content/test/performance/browser_startup_images.js! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)
Flags: needinfo?(jaws)
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fe8012cc708a
Add an extra selector for the urlbar-icon within the star-button-box now that the urlbar-icon for the bookmark star isn't a direct child of urlbar-icons. r=Gijs
Flags: needinfo?(jaws)
https://hg.mozilla.org/mozilla-central/rev/fe8012cc708a
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
Depends on: 1387161
Flags: qe-verify? → qe-verify-
You need to log in before you can comment on or make changes to this bug.