Closed
Bug 1385438
Opened 7 years ago
Closed 7 years ago
AtomicRefCounted doesn't need to use sequential consistency
Categories
(Core :: MFBT, enhancement, P2)
Core
MFBT
Tracking
()
RESOLVED
FIXED
mozilla58
Tracking | Status | |
---|---|---|
firefox58 | --- | fixed |
People
(Reporter: jrmuizel, Assigned: froydnj)
References
Details
Attachments
(1 file)
3.92 KB,
patch
|
jrmuizel
:
review+
|
Details | Diff | Splinter Review |
See https://doc.rust-lang.org/src/alloc/arc.rs.html#560 and https://stackoverflow.com/questions/28199212/why-does-libcs-implementation-of-shared-ptr-use-full-memory-barriers-instead
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → nfroyd
Priority: -- → P2
Assignee | ||
Comment 1•7 years ago
|
||
We don't need to use sequential consistency for everything, we can get by with using weaker memory consistency models depending on the operation.
Attachment #8922349 -
Flags: review?(jmuizelaar)
Reporter | ||
Updated•7 years ago
|
Attachment #8922349 -
Flags: review?(jmuizelaar) → review+
Pushed by nfroyd@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/cde4f36e7c23 make mozilla::RefCounted use the strongest memory consistency necessary; r=jrmuizel
Comment 3•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/cde4f36e7c23
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox58:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
See Also: → 1277709
See Also: → 1353181
You need to log in
before you can comment on or make changes to this bug.
Description
•