Closed Bug 1385440 Opened 7 years ago Closed 7 years ago

[sync-send tab] Only one device receives the link when "Send to All Devices" is clicked

Categories

(Firefox :: Sync, defect, P1)

56 Branch
defect

Tracking

()

VERIFIED FIXED
Firefox 57
Tracking Status
firefox56 --- verified
firefox57 --- verified

People

(Reporter: Abe_LV, Assigned: eoger)

Details

Attachments

(1 file)

Steps to Reproduce:

1. Open Nightly on three devices and log-in to sync to all of them
2. open any http or https link and right click on the page then hover over "Send Page to Device" and click "Send to All Devices"

Actual Result:
Only one of the devices receives the link

Expected Result:

All devices should receive the link
Flags: needinfo?(eoger)
I can reproduce this - the logs show us attempting to send them correctly, but the command only ends up in one client record. I suspect this is the same race we briefly discussed last week?
Flags: needinfo?(eoger)
Priority: -- → P1
Assignee: nobody → eoger
Status: NEW → ASSIGNED
Comment on attachment 8892957 [details]
Bug 1385440 - Serialize client commands additions.

https://reviewboard.mozilla.org/r/163966/#review169502

Awesome, thanks!
Attachment #8892957 - Flags: review?(markh) → review+
Pushed by eoger@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5b9526464192
Serialize client commands additions. r=markh
After this lands, let's verify it works correctly then request uplift ASAP - adding ni? on Ed so we don't forget this :)
Flags: needinfo?(eoger)
https://hg.mozilla.org/mozilla-central/rev/5b9526464192
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Comment on attachment 8892957 [details]
Bug 1385440 - Serialize client commands additions.

Approval Request Comment
[Feature/Bug causing the regression]: 1210296
[User impact if declined]: The "Send Tab to all devices" button will not work.
[Is this code covered by automated tests?]: Yes
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: -
[List of other uplifts needed for the feature/fix]: -
[Is the change risky?]: No
[Why is the change risky/not risky?]: The changes in the code are trivial and we introduced a test to make sure this regression wouldn't happen again.
[String changes made/needed]: -
Flags: needinfo?(eoger)
Attachment #8892957 - Flags: approval-mozilla-beta?
Andrei or Ioana - can you help to verify the fix in 57 before we uplift? Thanks.
Flags: needinfo?(chiorean.ioana)
Flags: needinfo?(andrei.vaida)
Is this a new feature? Does it need a release note?
Not really, this is mostly a fix.
(In reply to Liz Henry (:lizzard) (needinfo? me) from comment #8)
> Andrei or Ioana - can you help to verify the fix in 57 before we uplift?
> Thanks.
I will ask Ninu and Sorina, they handle FxA testing. I think they can verify desktop side too (or maybe Kanchan if not)
Flags: needinfo?(sorina.florean)
Flags: needinfo?(mihai.ninu)
Flags: needinfo?(chiorean.ioana)
Flags: needinfo?(andrei.vaida)
Verified as fixed on the latest Nightly build (57.0a1 - 08/08/2017)
This issue was tested by sending from the desktop build to all synced devices (list below). The sent tab was received on all devices.

Samsung Galaxy S6 EDGE - Android 7.0
LG G5 - Android 6.0.1
Nexus 6P - Android 8
Samsung Galaxy Tab S3 - Android 7.0
HTC ONE M9 - Android 6.0
Flags: needinfo?(sorina.florean)
Flags: needinfo?(mihai.ninu)
Comment on attachment 8892957 [details]
Bug 1385440 - Serialize client commands additions.

Thanks very much for the verification!
Let's uplift this fix for 56 beta 2.
Attachment #8892957 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Tested again using the latest Beta build on desktop (56.0b2) and latest beta on mobile (56.0b1) and I can confirm that this issue has been fixed. 
I will verify it as fixed on Wednesday(August 16th) when we have a new beta on mobile.

Devices used: 
Nexus 6P - Android 8
LG v20 - Android 7.0
ONEPLUS A3000 - Android 6.0.1
Xiaomi mi I4 - Android 5.0.2
Verified Fixed based on Comment 12 and Comment 15.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.