1385444 - Remove support for "skin" chrome registration after removing support for complete themes

Status: NEW

(Toolkit :: Add-ons Manager, enhancement, P3)

Description

[Matthew N. [:MattN]]

Once we no longer support complete themes replacing "skin" packages, we can simply our chrome registration and architecture by removing support for "skin" and moving everything to "content". This is option (A) in the email to firefox-dev[1] which bsmedberg supported. My only concern is whether there potential to introduce security issues since the "content" package is chrome privileged.

We probably need dependency bugs to merge/move existing skin contents.

[1] https://developer.mozilla.org/en-US/docs/Chrome_Registration#skin

Comment 1

[Dão Gottwald [::dao]]

(In reply to Matthew N. [:MattN] (huge backlog; PM if requests are blocking you) from comment #0)
> Once we no longer support complete themes replacing "skin" packages, we can
> simply our chrome registration and architecture by removing support for
> "skin" and moving everything to "content".

And while we're at it, maybe we get rid of content/? Is there a reason to prefer chrome://browser/content/browser.js over chrome://browser/browser.js?

Comment 2

[Dave Townsend [:mossop]]

(In reply to Dão Gottwald [::dao] from comment #1)
> (In reply to Matthew N. [:MattN] (huge backlog; PM if requests are blocking
> you) from comment #0)
> > Once we no longer support complete themes replacing "skin" packages, we can
> > simply our chrome registration and architecture by removing support for
> > "skin" and moving everything to "content".
> 
> And while we're at it, maybe we get rid of content/? Is there a reason to
> prefer chrome://browser/content/browser.js over chrome://browser/browser.js?

We probably need to keep that until the locale parts go away.