Open Bug 1385470 Opened 7 years ago Updated 2 years ago

Save to Pocket "library animation" doesn't play if I dismiss the popup quickly

Categories

(Firefox :: Pocket, defect, P4)

defect

Tracking

()

People

(Reporter: dholbert, Unassigned)

References

Details

Attachments

(1 file)

STR
 0. Log in to pocket, and also use "Customize" to drag the library icon onto your toolbar (so that the pocket-library animation can be played)

 1. Visit https://example.org (or any page)

 2. Click the pocket icon.

 3. As fast as possible, click a blank space in the tab, so that the pocket doorhanger is dismissed.

EXPECTED RESULTS:
 - The save-to-pocket library animation should still play.

ACTUAL RESULTS:
 - The pocket animation does not play.
 - Additionally: this gets logged to my browser console:
> Pocket panel frame content window is undefined  main.js:729:13

The warning comes from this line:
https://dxr.mozilla.org/mozilla-central/rev/36f95aeb4c77f7cf3b3366583008cd6e4b6b1dba/browser/extensions/pocket/content/main.js#729
Attached video screencast of bug
Here's a screencast of this bug. I perform the STR multiple times in this screencast.

(On the third time, I pause for a bit as the dialog appears, and *that time* the animation plays. None of the other attempts get an animation, though.)
Component: General → Pocket
Whiteboard: [photon-animation][triage]
Whiteboard: [photon-animation][triage]
Jared, this got dropped from animations, was that intentional? If so, can you assign a priority with some brief comment as to rationale? Thanks!
Flags: needinfo?(jaws)
This is actually acting by design (in some respects).

Pocket doesn't actually save the page until the panel contents are loaded and you can see the "Saved to Pocket" text. Before then the user would just see "Saving...". We only run the animation if the page was successfully saved to Pocket, and thus closing the popup before the page can be saved results in no follow-up animation.
Flags: needinfo?(jaws)
The larger bug at play is that Pocket doesn't save pages on a background worker, everything is run through the Pocket panel contents and triggered off of those results. This is a result of how the Pocket add-on was implemented and isn't a behavior change in 57.
Priority: -- → P4
(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #3)
> Pocket doesn't actually save the page until the panel contents are loaded
> and you can see the "Saved to Pocket" text. Before then the user would just
> see "Saving...".

This doesn't match my experience locally.  I see three different behaviors, depending on when I click to dismiss the popup:

 1. If I click *immediately* (while the popup is blank), then you're right -- Pocket doesn't save the page.
 2. If I wait a fraction of a second until I see "Saving..." and then click, then Pocket *does* save the page (but the library animation does not play).
 3. If I wait a bit longer for the "Saved to Pocket", then the page saves, and the library animation plays, and the pocket icon in the URL bar turns solid.

Behaviors #1 and #2 are the ones that are broken (and differently broken).
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: