1385474 - Avoid QIing in NoteXPCOMRoot

Status: RESOLVED FIXED

(Core :: XPCOM, enhancement)

Description

[Andrew McCreight [:mccr8]]

This is used in very limited ways, so just require that callers pass in canonical nsISupports objects, and the participant.

Comment 1

[Andrew McCreight [:mccr8]]

I split this off from bug 1385459 to reduce the risk of backporting that bug if want end up wanting to do that. I expect the perf gains here to be minor, as this is only used during the CC proper.

Comment 2

[Andrew McCreight [:mccr8]]

Attachment: Bug 1385474 - Avoid QIing for NoteXPCOMRoot.

This callback is only used in very limited ways, so just require that
the caller pass in the canonical supports pointer, plus the
participant. This probably won't affect performance much.

Review commit: https://reviewboard.mozilla.org/r/162742/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/162742/

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8891666 [details]
Bug 1385474 - Avoid QIing for NoteXPCOMRoot.

https://reviewboard.mozilla.org/r/162742/#review168466

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8d09df72c2e9
Avoid QIing for NoteXPCOMRoot. r=smaug

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/8d09df72c2e9