Closed Bug 1385474 Opened 4 years ago Closed 4 years ago

Avoid QIing in NoteXPCOMRoot

Categories

(Core :: XPCOM, enhancement)

Product:
Core
Component:
XPCOM
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla56
Tracking Flags:
Tracking Status
firefox56 --- fixed

People

(Reporter: mccr8, Assigned: mccr8)

References

Details

Attachments

(1 file)

Bug 1385474 - Avoid QIing for NoteXPCOMRoot.
59 bytes, text/x-review-board-request
smaug
: review+
Details 
This is used in very limited ways, so just require that callers pass in canonical nsISupports objects, and the participant.
I split this off from bug 1385459 to reduce the risk of backporting that bug if want end up wanting to do that. I expect the perf gains here to be minor, as this is only used during the CC proper.
Comment on attachment 8891666 [details]
Bug 1385474 - Avoid QIing for NoteXPCOMRoot.

https://reviewboard.mozilla.org/r/162742/#review168466
Attachment #8891666 - Flags: review?(bugs) → review+
Pushed by amccreight@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8d09df72c2e9
Avoid QIing for NoteXPCOMRoot. r=smaug
https://hg.mozilla.org/mozilla-central/rev/8d09df72c2e9
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.