Closed Bug 1385491 Opened 2 years ago Closed 2 years ago

Avoid bug 1372824 in the face of bug 1385396

Categories

(Firefox :: General, enhancement)

54 Branch
enhancement
Not set

Tracking

()

RESOLVED FIXED
Firefox 56
Tracking Status
firefox56 --- fixed

People

(Reporter: mrbkap, Assigned: mrbkap)

Details

Attachments

(1 file)

I found recently that bug 1385396 will regress bug 1372824 on beta because we're initializing gfx too early in startup and caching the default e10s "off" value before the rollout addon has a chance to set the pref.

I propose adding to the house of cards by setting the pref before setting the cohort, causing us to cache the correct value in setCohort. With any luck, by Firefox 57, we'll be able to set the default to true for everybody and get rid of all of this code.
Comment on attachment 8891561 [details]
Bug 1385491 - Call setCohort after setting e10s prefs.

https://reviewboard.mozilla.org/r/162680/#review168514

Reminder to bump the version in install.rdf
Attachment #8891561 - Flags: review?(felipc) → review+
Pushed by mrbkap@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8dded44b0fef
Call setCohort after setting e10s prefs. r=Felipe
https://hg.mozilla.org/mozilla-central/rev/8dded44b0fef
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
You need to log in before you can comment on or make changes to this bug.