1385539 - mozbuild.configure.ConfigureSandbox.include_file has incomplete documentation.

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Description

[Tom Prince [:tomprince]]

The first paragraph of the docstring is an incomplete sentence:

"Include one file in the sandbox. Users of this class probably want"

This was introduced in https://reviewboard.mozilla.org/r/45965/diff/1#index_header

Comment 1

[Tom Prince [:tomprince]]

Attachment: Bug 1385539 - Re-add accidentally deleted documentation of mozbuild.configure.ConfigureSandbox.include_file;

Review commit: https://reviewboard.mozilla.org/r/162714/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/162714/

Comment 2

[Mike Hommey [:glandium]]

Comment on attachment 8891604 [details]
Bug 1385539 - Re-add accidentally deleted documentation of mozbuild.configure.ConfigureSandbox.include_file;

https://reviewboard.mozilla.org/r/162714/#review169484

Please add to the commit message that this was removed in bug 1256571.

Comment 3

[Tom Prince [:tomprince]]

Comment on attachment 8891604 [details]
Bug 1385539 - Re-add accidentally deleted documentation of mozbuild.configure.ConfigureSandbox.include_file;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/162714/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b3778db09581
Re-add accidentally deleted documentation of mozbuild.configure.ConfigureSandbox.include_file; r=glandium

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/b3778db09581