Closed
Bug 1385547
Opened 7 years ago
Closed 7 years ago
Add eslint rules for requiring semicolons and disallowing init to undefined
Categories
(Remote Protocol :: Marionette, enhancement)
Tracking
(firefox56 fixed)
RESOLVED
FIXED
mozilla56
Tracking | Status | |
---|---|---|
firefox56 | --- | fixed |
People
(Reporter: ato, Assigned: ato)
Details
Attachments
(2 files)
1.25 KB,
patch
|
automatedtester
:
review+
|
Details | Diff | Splinter Review |
21.21 KB,
patch
|
automatedtester
:
review+
|
Details | Diff | Splinter Review |
Under testing/marionette, we always use semicolons for consistency and we never initialise a scoped variable to undefined because it is the default value. Disallowed: > let foo = undefined; > return foo Allowed: > const foo = undefined; > let bar; > return bar;
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → ato
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•7 years ago
|
||
Under testing/marionette, we always use semicolons for consistency and we never initialise scoped variables to undefined becuase it is the default value. We also indent continued call expressions by four characters. Disallowed: let foo = undefined; return foo Allowed: const foo = undefined; let bar; return bar; MozReview-Commit-ID: LgVPMqnFqNk
Assignee | ||
Comment 2•7 years ago
|
||
Automatic fixes from './mach lint --fix testing/marionette'. MozReview-Commit-ID: 4UOLrLLxMbH
Assignee | ||
Updated•7 years ago
|
Attachment #8891617 -
Flags: review?(dburns)
Assignee | ||
Updated•7 years ago
|
Attachment #8891618 -
Flags: review?(dburns)
Assignee | ||
Comment 3•7 years ago
|
||
try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=f22a46d681d217a73cbba9cf3cb0c479a4e3658f
Updated•7 years ago
|
Attachment #8891617 -
Flags: review?(dburns) → review+
Updated•7 years ago
|
Attachment #8891618 -
Flags: review?(dburns) → review+
Pushed by atolfsen@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/423b51b21519 Tighten eslint rules on semicolons and init to undefined. r=automatedtester https://hg.mozilla.org/integration/mozilla-inbound/rev/9360c4975d36 Lint testing/marionette. r=automatedtester
Comment 5•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/423b51b21519 https://hg.mozilla.org/mozilla-central/rev/9360c4975d36
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Updated•1 year ago
|
Product: Testing → Remote Protocol
You need to log in
before you can comment on or make changes to this bug.
Description
•