1385563 - Resource leak - File descriptor on the directory is not closed

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, defect)

Description

[Sylvestre Ledru [:Sylvestre]]

in crashreporter_unix_common.cpp, dirfd is not closed

Comment 1

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1385563 - Resource leak - Close the file descriptor

Review commit: https://reviewboard.mozilla.org/r/162726/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/162726/

Comment 2

[(not currently active) Ted Mielczarek]

Comment on attachment 8891625 [details]
Bug 1385563 - Resource leak - Close the file descriptor

https://reviewboard.mozilla.org/r/162726/#review172818

::: toolkit/crashreporter/client/crashreporter_unix_common.cpp:72
(Diff revision 1)
>      UIDeleteFile(path.c_str());
>  
>      dumpfiles.pop_back();
>    }
> +
> +  closedir(dirfd);

I would probably put this right after the while loop that uses it.

Comment 3

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8891625 [details]
Bug 1385563 - Resource leak - Close the file descriptor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/162726/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/92df025b153e
Resource leak - Close the file descriptor r=ted

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/92df025b153e