Closed Bug 1385563 Opened 3 years ago Closed 3 years ago
Resource leak - File descriptor on the directory is not closed
59 bytes, text/x-review-board-request
in crashreporter_unix_common.cpp, dirfd is not closed
Comment on attachment 8891625 [details] Bug 1385563 - Resource leak - Close the file descriptor https://reviewboard.mozilla.org/r/162726/#review172818 ::: toolkit/crashreporter/client/crashreporter_unix_common.cpp:72 (Diff revision 1) > UIDeleteFile(path.c_str()); > > dumpfiles.pop_back(); > } > + > + closedir(dirfd); I would probably put this right after the while loop that uses it.
Attachment #8891625 - Flags: review?(ted) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/92df025b153e Resource leak - Close the file descriptor r=ted
You need to log in before you can comment on or make changes to this bug.