1385642 - L10n Dailies on Mac broken since 2017-07-14 - InvalidOptionError: RUSTFLAGS is not available in this configuration

Status: RESOLVED FIXED

(Thunderbird :: Build Config, defect)

Description

[Jorg K (CEST = GMT+2)]

In general, l10n Dailies are a big pain. They break constantly and there is no system to monitor them so we notice weeks later.

At time of writing, Mac and Linux l10n dailies are broken, see:
http://ftp.mozilla.org/pub/thunderbird/nightly/2017/07/2017-07-29-03-02-07-comm-central-l10n/

A Mac log says:
mozbuild.configure.options.InvalidOptionError: RUSTFLAGS is not available in this configuration
*** Fix above errors and then restart with               "make -f client.mk build"

A Linux log says:
ImportError: cannot import name check_output
program finished with exit code 1

The last successful run for all platforms was on 2017-07-13. Discussion on IRC mentions that the restriction to Python 2.7 could be a problem, but that got loosened to 2.6 today in bug 1385435, but l10n Dailies didn't return. Oh, bug 1385435 comment #2 mentions that some action is required re. "check_output".

Whilst that will fix Linux, I'm not sure it will also fix Mac.

In any case, it would be good to have some indication on the Daily run to see whether the l10n run was successful or not, since, as mentioned, we notice way to late.

Comment 1

[Axel Hecht [:Pike]]

The problem here is that RUSTFLAGS is incompatible with --disable-compile-environment.

And on windows, we don't disable the compile environment for l10n builds, but it also seems that we're not passing RUSTFLAGS there. Or at least not in the way that we do in linux 64 (the only other log I looked at).

Note, this bug isn't really actionable as filed.

And my assumption is that the way the visibility gets fixed is to port the builds to taskcluster, and which point the builds will probably show up on treeherder as they do for fx.

Comment 2

[Jorg K (CEST = GMT+2)]

(In reply to Axel Hecht [:Pike] from comment #1)
> Note, this bug isn't really actionable as filed.
Yes, I'm sorry, let's make it actionable.

I threw issues into this bug:
1) Daily l10n not working on Mac:
   InvalidOptionError: RUSTFLAGS is not available in this configuration
2) Daily l10n not working on Linux:
   ImportError: cannot import name check_output
   Taken care of in bug 1385435.
3) It's hard to notice when l10n Dailies fail.

Let's hope that TaskCluster will fix issue 3), 2) is taken care of elsewhere, that leaves issue 1). So adapting the summary accordingly.

Please note that the --disable-compile-environment story is endless, we've enabled it, disabled it, re-enabled it on the various platforms, a summary is here: Bug 1345422 comment #58 which states that this *is* required on Mac:
https://dxr.mozilla.org/comm-central/rev/f593d2d106c15ad9682a35eaa1a8679e7127acd6/mail/config/mozconfigs/macosx64/l10n-mozconfig#6

I'm sure Tom will gain a better understanding of it.

Comment 3

[Tom Prince [:tomprince]]

> 3) It's hard to notice when l10n Dailies fail.

It should be possible to improve this even before we get to taskcluster.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/f17246b9aa74
Don't set RUSTFLAGS on MacOS while generating nightly l10n repacks; rs=bustage-fix