1385693 - firefox crashes when saving a file if glib is compiled with --enable-gc-friendly.

Status: RESOLVED WORKSFORME

(Core :: Widget: Gtk, defect, P3)

Description

[Hussam Al-Tayeb]

Attachment: gdb.txt

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/604.1 (KHTML, like Gecko) Version/11.0 Safari/604.1 Epiphany/3.24.3

Steps to reproduce:

Firefox crashes when using the gtk3 file chooser.
To reproduce, you need gtk3 3.22.17 and glib 2.53.x (I use 2.53.4).
Note: This only happens in firefox. epiphany browser, libreoffice, and native gtk3 applications do not crash.
I am using official mozilla build.


Actual results:

I am attaching the backtrace.

Comment 1

[Hussam Al-Tayeb]

temporary copy with syntax highlighting https://paste.gnome.org/psbmdcotx

Comment 2

[Hussam Al-Tayeb]

Sorry for the noise. This was something I missed up locally in glib. It's not a glib or firefox bug.

Comment 3

[Hussam Al-Tayeb]

Reopening: I found out how to easily reproduce.

Comment 4

[Emma Humphries ☕️🎸🧞‍♀️✨ (she/they) [:emceeaich] (Pacific Time) use needinfo]

Would you provide the steps to reproduce this? Thank you.

Comment 5

[Hussam Al-Tayeb]

Sure.
- Compile glib 2.54 with -g cflag (-g enables a debug build) and --enable-gc-friendly ./configure option.
- Open firefox and some website such as https://bugzilla.mozilla.org/show_bug.cgi?id=1385693
- Press ctrl-s on your keyboard and notice the frozen gtk+ file dialog.
- wait a few seconds and firefox crashes.
Native gtk+ applications can still use the file dialog just fine. Only Firefox breaks.

Now remove the --enable-gc-friendly ./configure option in glib and firefox does not crash anymore.

Comment 6

[Emma Humphries ☕️🎸🧞‍♀️✨ (she/they) [:emceeaich] (Pacific Time) use needinfo]

Tracy, let me know what you want to do with this? Is this now a build config bug on other platforms?

Comment 7

[Hussam Al-Tayeb]

It is probably related to how Firefox uses the native gtk+ file chooser dialog. Gtk+ pulls in glib/gio.

Comment 8

[Sylvestre Ledru [:Sylvestre]]

Moving to p3 because no activity for at least 1 year(s).
See https://github.com/mozilla/bug-handling/blob/master/policy/triage-bugzilla.md#how-do-you-triage for more information

Comment 9

[Andrei Purice]

Hey Hussam,
Can you still reproduce this issue or should we close it?

Comment 10

[Hussam Al-Tayeb]

(In reply to Andrei Purice from comment #9)

Hey Hussam,
Can you still reproduce this issue or should we close it?

You can close it since the GC friendly option is gone in glib when they ported away from autotools.