Closed Bug 1385716 Opened 7 years ago Closed 7 years ago

Add geo-based sites/stories, CSP tag and bug fixes to Activity Stream

Categories

(Firefox :: New Tab Page, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 57
Tracking Status
firefox56 --- fixed
firefox57 --- fixed

People

(Reporter: Mardak, Assigned: Mardak)

References

Details

(Whiteboard: [export])

User Story

https://github.com/mozilla/activity-stream/compare/8c7a4d9424c615d4dddb4e68ef4d9d90eaefcc93...729f4c653209e6af0df98fcbd94709b794aeebcd

Attachments

(1 file)

      No description provided.
Depends on: 1385867
Depends on: 1385871
User Story: (updated)
Summary: Add ... and bug fixes to Activity Stream → Add geo-based sites/stories, CSP tag and bug fixes to Activity Stream
Comment on attachment 8892321 [details]
Bug 1385716 - Add geo-based sites/stories, CSP tag and bug fixes to Activity Stream.

https://reviewboard.mozilla.org/r/163288/#review168826

thanks ed!
Attachment #8892321 - Flags: review?(usarracini) → review+
Pushed by edilee@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/3aa0d5effba3
Add geo-based sites/stories, CSP tag and bug fixes to Activity Stream. r=ursula
Blocks: 1386314
Blocks: 1386785
https://hg.mozilla.org/mozilla-central/rev/3aa0d5effba3
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Comment on attachment 8892321 [details]
Bug 1385716 - Add geo-based sites/stories, CSP tag and bug fixes to Activity Stream.

Approval Request Comment (part 1 of 6 Mardak will uplift)
[Feature/Bug causing the regression]: Activity Stream preffed off in 56 to be enabled in Shield study
[User impact if declined]: Users in the "wrong" regions could see sites and stories that aren't relevant
[Is this code covered by automated tests?]: Yes, Activity Stream has 100% line coverage
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: Bug 1386265 Bug 1386350 Bug 1385090 Bug 1386314 Bug 1386737
[Is the change risky?]: No
[Why is the change risky/not risky?]: The feature is preffed off
[String changes made/needed]: Localized strings were added
Attachment #8892321 - Flags: approval-mozilla-beta?
Assignee: nobody → edilee
Comment on attachment 8892321 [details]
Bug 1385716 - Add geo-based sites/stories, CSP tag and bug fixes to Activity Stream.

Fix permafails on beta, let's uplift this first.
Attachment #8892321 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
(In reply to Ed Lee :Mardak from comment #5)
> [Is this code covered by automated tests?]: Yes, Activity Stream has 100%
> line coverage
> [Has the fix been verified in Nightly?]: Yes
> [Needs manual test from QE? If yes, steps to reproduce]: No

Setting qe-verify- based on Ed Lee's assessment on manual testing needs and the fact that this fix has automated coverage.
Flags: qe-verify-
Whiteboard: [export]
Component: Activity Streams: Newtab → New Tab Page
You need to log in before you can comment on or make changes to this bug.