Closed Bug 1385726 Opened 5 years ago Closed 1 year ago

Use IME_FLAG_NO_PERSONALIZED_LEARNING definition provided by support library

Categories

(Firefox for Android Graveyard :: Keyboards and IME, enhancement, P5)

All
Android
enhancement

Tracking

(Not tracked)

RESOLVED INCOMPLETE

People

(Reporter: JanH, Unassigned)

References

Details

Once we've switched to use at least v26 of the support library, we should replace our definition of IME_FLAG_NO_PERSONALIZED_LEARNING with the official one provided by the support library in EditorInfoCompat (https://developer.android.com/reference/android/support/v13/view/inputmethod/EditorInfoCompat.html#IME_FLAG_NO_PERSONALIZED_LEARNING).
Depends on: 1266683
Re-triaging per https://bugzilla.mozilla.org/show_bug.cgi?id=1473195

Needinfo :susheel if you think this bug should be re-triaged.
Priority: -- → P5

We're currently not using the support-v13 library which contains that flag definition. Adding it seems to increase our classes.dex-size by ~2 kB even after proguarding if I didn't misread the Perfherder comparison. This isn't much in the big scheme of things, but still seems excessive for a simple constant.

So I'd just leave this alone until we need that support library for other reasons, too.

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → INCOMPLETE
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.