1385743 - build-clang.py fails to build recent trunk on windows

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

Traceback (most recent call last):
  File "build/src/build/build-clang/build-clang.py", line 496, in <module>
    symlink(l[0], l[1])
  File "build/src/build/build-clang/build-clang.py", line 31, in symlink
    copy_dir_contents(source, link_name)
  File "build/src/build/build-clang/build-clang.py", line 109, in copy_dir_contents
    shutil.copy2(f, destname)
  File "c:\mozilla-build\python\Lib\shutil.py", line 130, in copy2
    copyfile(src, dst)
  File "c:\mozilla-build\python\Lib\shutil.py", line 83, in copyfile
    with open(dst, 'wb') as fdst:
IOError: [Errno 2] No such file or directory: 'Z:\\task_1501385262\\llvm-sources/src/llvm/projects/libcxx/appveyor-reqs-install.cmd'

Comment 1

[Ting-Yu Chou [:ting] (away)]

It's because the first |f| to copy in copy_dir_contents() is a file not a directory which the destination directory haven't been created yet, so copy2() raises the error. If the first |f| is a directory, copytree() will create the target directory.

delete Z:\task_1502879543\llvm-sources/src/llvm/projects/libcxx
copy Z:\task_1502879543\llvm-sources/src/libcxx\appveyor-reqs-install.cmd to Z:\task_1502879543\llvm-sources/src/llvm/projects/libcxx/appveyor-reqs-install.cmd
Traceback (most recent call last):
  File "build/src/build/build-clang/build-clang.py", line 492, in <module>
    symlink(l[0], l[1])
  File "build/src/build/build-clang/build-clang.py", line 29, in symlink
    copy_dir_contents(source, link_name)
  File "build/src/build/build-clang/build-clang.py", line 103, in copy_dir_contents
    shutil.copy2(f, destname)
  File "c:\mozilla-build\python\Lib\shutil.py", line 130, in copy2
    copyfile(src, dst)
  File "c:\mozilla-build\python\Lib\shutil.py", line 83, in copyfile
    with open(dst, 'wb') as fdst:
IOError: [Errno 2] No such file or directory: 'Z:\\task_1502879543\\llvm-sources/src/llvm/projects/libcxx/appveyor-reqs-install.cmd'

Comment 2

[Ting-Yu Chou [:ting] (away)]

Attachment: Bug 1385743 - Use copy_tree() to copy directory recursively instead.

shutil.copy2() will fail if the destination directory isn't existed.
Switch to copy_tree() instead so we don't need to worry about the
error cases of copy2() and copytree().

Review commit: https://reviewboard.mozilla.org/r/169462/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/169462/

Comment 3

[Ting-Yu Chou [:ting] (away)]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=e9577e4931c77a50a140118e814ba85ac569ea88&group_state=expanded

Comment 4

[(no longer active)]

Comment on attachment 8898122 [details]
Bug 1385743 - Use copy_tree() to copy directory recursively instead.

https://reviewboard.mozilla.org/r/169462/#review174898

Wow, thank you!  I didn't know Python has a built-in way to do this.  Much better!

::: commit-message-6ebc2:3
(Diff revision 1)
> +Bug 1385743 - Use copy_tree() to copy directory recursively instead. r?ehsan
> +
> +shutil.copy2() will fail if the destination directory isn't existed.

Nit: s/isn't existed/doesn't exist/  :-)

Comment 5

[Ting-Yu Chou [:ting] (away)]

Comment on attachment 8898122 [details]
Bug 1385743 - Use copy_tree() to copy directory recursively instead.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/169462/diff/1-2/

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/156a87d9fb99
Use copy_tree() to copy directory recursively instead. r=Ehsan

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/156a87d9fb99