build-clang.py doesn't handle the llvm source cache properly

RESOLVED FIXED

Status

()

Core
Build Config
RESOLVED FIXED
3 months ago
3 months ago

People

(Reporter: glandium, Assigned: glandium)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

3 months ago
Windows clang-cl builds are using a llvm source cache, presumably to make the build faster, but it fails to use it properly, leading to surprising results. Most notably, if one tries to push a different branch than trunk and hit the cache, the result will still be from the trunk branch, because the svn update calls just update to the revision without doing anything about the repo url.
(Assignee)

Updated

3 months ago
Assignee: nobody → mh+mozilla
Comment hidden (mozreview-request)

Comment 2

3 months ago
mozreview-review
Comment on attachment 8892862 [details]
Bug 1385744 - Stop using a cache for the llvm source.

https://reviewboard.mozilla.org/r/163876/#review169376

Caches are one of the hardest problems in computer science!
Attachment #8892862 - Flags: review?(gps) → review+

Comment 3

3 months ago
Pushed by mh@glandium.org:
https://hg.mozilla.org/mozilla-central/rev/22ad2f44b6f8
Stop using a cache for the llvm source. r=gps
(Assignee)

Updated

3 months ago
Status: NEW → RESOLVED
Last Resolved: 3 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.