Closed
Bug 1385748
Opened 7 years ago
Closed 7 years ago
Remove MDSM::IsLogicallyPlaying()
Categories
(Core :: Audio/Video: Playback, enhancement, P5)
Core
Audio/Video: Playback
Tracking
()
RESOLVED
FIXED
mozilla56
Tracking | Status | |
---|---|---|
firefox56 | --- | fixed |
People
(Reporter: jwwang, Assigned: jwwang)
Details
Attachments
(3 files)
It has no callers at all.
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → jwwang
Priority: -- → P5
Assignee | ||
Updated•7 years ago
|
Component: Audio/Video: Recording → Audio/Video: Playback
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Attachment #8891863 -
Flags: review?(kaku)
Attachment #8891864 -
Flags: review?(kaku)
Attachment #8891865 -
Flags: review?(kaku)
Comment 4•7 years ago
|
||
mozreview-review |
Comment on attachment 8891863 [details] Bug 1385748. P1 - remove MDSM::IsLogicallyPlaying() which has no callers at all. https://reviewboard.mozilla.org/r/162876/#review168176
Attachment #8891863 -
Flags: review?(kaku) → review+
Comment 5•7 years ago
|
||
mozreview-review |
Comment on attachment 8891864 [details] Bug 1385748. P2 - remove MDSM::mNextPlayState. https://reviewboard.mozilla.org/r/162878/#review168178
Attachment #8891864 -
Flags: review?(kaku) → review+
Comment 6•7 years ago
|
||
mozreview-review |
Comment on attachment 8891865 [details] Bug 1385748. P3 - MediaDecoder::mNextState doesn't need to be a canonical for it has no mirrors. https://reviewboard.mozilla.org/r/162880/#review168180
Attachment #8891865 -
Flags: review?(kaku) → review+
Assignee | ||
Comment 7•7 years ago
|
||
Thanks!
Pushed by jwwang@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f76639bd1c36 P1 - remove MDSM::IsLogicallyPlaying() which has no callers at all. r=kaku https://hg.mozilla.org/integration/autoland/rev/47380ed038da P2 - remove MDSM::mNextPlayState. r=kaku https://hg.mozilla.org/integration/autoland/rev/42d64afd61ab P3 - MediaDecoder::mNextState doesn't need to be a canonical for it has no mirrors. r=kaku
Comment 9•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/f76639bd1c36 https://hg.mozilla.org/mozilla-central/rev/47380ed038da https://hg.mozilla.org/mozilla-central/rev/42d64afd61ab
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in
before you can comment on or make changes to this bug.
Description
•