Closed Bug 1385748 Opened 3 years ago Closed 3 years ago

Remove MDSM::IsLogicallyPlaying()

Categories

(Core :: Audio/Video: Playback, enhancement, P5)

enhancement

Tracking

()

RESOLVED FIXED
mozilla56
Tracking Status
firefox56 --- fixed

People

(Reporter: jwwang, Assigned: jwwang)

Details

Attachments

(3 files)

It has no callers at all.
Assignee: nobody → jwwang
Priority: -- → P5
Component: Audio/Video: Recording → Audio/Video: Playback
Attachment #8891863 - Flags: review?(kaku)
Attachment #8891864 - Flags: review?(kaku)
Attachment #8891865 - Flags: review?(kaku)
Comment on attachment 8891863 [details]
Bug 1385748. P1 - remove MDSM::IsLogicallyPlaying() which has no callers at all.

https://reviewboard.mozilla.org/r/162876/#review168176
Attachment #8891863 - Flags: review?(kaku) → review+
Comment on attachment 8891864 [details]
Bug 1385748. P2 - remove MDSM::mNextPlayState.

https://reviewboard.mozilla.org/r/162878/#review168178
Attachment #8891864 - Flags: review?(kaku) → review+
Comment on attachment 8891865 [details]
Bug 1385748. P3 - MediaDecoder::mNextState doesn't need to be a canonical for it has no mirrors.

https://reviewboard.mozilla.org/r/162880/#review168180
Attachment #8891865 - Flags: review?(kaku) → review+
Thanks!
Pushed by jwwang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f76639bd1c36
P1 - remove MDSM::IsLogicallyPlaying() which has no callers at all. r=kaku
https://hg.mozilla.org/integration/autoland/rev/47380ed038da
P2 - remove MDSM::mNextPlayState. r=kaku
https://hg.mozilla.org/integration/autoland/rev/42d64afd61ab
P3 - MediaDecoder::mNextState doesn't need to be a canonical for it has no mirrors. r=kaku
You need to log in before you can comment on or make changes to this bug.