Closed Bug 1385751 Opened 3 years ago Closed 3 years ago

Suppress the annoying warnings of flaky timeouts in media tests

Categories

(Core :: Audio/Video: Playback, enhancement, P5)

Product:
Core
Component:
Audio/Video: Playback
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla56
Tracking Flags:
Tracking Status
firefox56 --- fixed

People

(Reporter: jwwang, Assigned: jwwang)

Details

Attachments

(1 file)

Bug 1385751 - suppress the annoying warnings of flaky timeouts in media tests.
59 bytes, text/x-review-board-request
gerald
: review+
Details 
http://searchfox.org/mozilla-central/rev/09c065976fd4f18d4ad764d7cb4bbc684bf56714/dom/media/test/manifest.js#1697

The timer is used to detect test timeout and will not introduce indeterministic. So it should be OK to call SimpleTest._originalSetTimeout() instead to bypass the warning.

http://searchfox.org/mozilla-central/rev/09c065976fd4f18d4ad764d7cb4bbc684bf56714/dom/media/test/eme.js#320
Assignee: nobody → jwwang
Priority: -- → P5
Attachment #8891866 - Flags: review?(gsquelart)
Summary: Surpress the annoying warnings of flaky timeouts in media tests → Suppress the annoying warnings of flaky timeouts in media tests
Comment on attachment 8891866 [details]
Bug 1385751 -  suppress the annoying warnings of flaky timeouts in media tests.

https://reviewboard.mozilla.org/r/162884/#review168204

::: commit-message-0909f:1
(Diff revision 1)
> +Bug 1385751 - surpress the annoying warnings of flaky timeouts in media tests.

'surpress' -> 'suppress'
Attachment #8891866 - Flags: review?(gsquelart) → review+
Comment on attachment 8891866 [details]
Bug 1385751 -  suppress the annoying warnings of flaky timeouts in media tests.

https://reviewboard.mozilla.org/r/162884/#review168204

> 'surpress' -> 'suppress'

Thanks!
Pushed by jwwang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3bcd8efdd376
suppress the annoying warnings of flaky timeouts in media tests. r=gerald
https://hg.mozilla.org/mozilla-central/rev/3bcd8efdd376
Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.