[Form Autofill] Group tel-related fields when calculating the secondary label

RESOLVED FIXED in Firefox 56

Status

()

enhancement
P3
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: lchang, Assigned: lchang)

Tracking

(Blocks 1 bug)

52 Branch
mozilla56
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox56 fixed)

Details

(Whiteboard: [form autofill:M4])

Attachments

(1 attachment)

We should avoid picking another tel-related fields as a secondary label when we're already focusing a tel field.
Assignee

Updated

2 years ago
Assignee: nobody → lchang
Comment hidden (mozreview-request)
Assignee

Updated

2 years ago
Status: NEW → ASSIGNED

Comment 3

2 years ago
mozreview-review
Comment on attachment 8891895 [details]
Bug 1385753 - [Form Autofill] Group tel-related fields when calculating the secondary label.

https://reviewboard.mozilla.org/r/162916/#review168212

::: browser/extensions/formautofill/ProfileAutoCompleteResult.jsm:190
(Diff revision 2)
> +        "tel-country-code",
> +        "tel-national",
> +        "tel-area-code",
> +        "tel-local",
> +        "tel-local-prefix",
> +        "tel-local-suffix",

Should we add "tel-extension" here as well? Not sure, but I feel like they're related.

Comment 4

2 years ago
mozreview-review
Comment on attachment 8891895 [details]
Bug 1385753 - [Form Autofill] Group tel-related fields when calculating the secondary label.

https://reviewboard.mozilla.org/r/162916/#review168214

LGTM, thanks :)
Attachment #8891895 - Flags: review?(ralin) → review+
Thanks for the review.


(In reply to Ray Lin[:ralin] from comment #3)
> Should we add "tel-extension" here as well? Not sure, but I feel like
> they're related.

They're related indeed. However, "tel-extension" isn't supported in MVP so I would prefer to add it until we need it.

Comment 6

2 years ago
Pushed by lchang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3a7473bd9db5
[Form Autofill] Group tel-related fields when calculating the secondary label. r=ralin

Comment 7

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/3a7473bd9db5
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.