Closed Bug 1385753 Opened 3 years ago Closed 3 years ago

[Form Autofill] Group tel-related fields when calculating the secondary label

Categories

(Toolkit :: Form Manager, enhancement, P3)

52 Branch
enhancement

Tracking

()

RESOLVED FIXED
mozilla56
Tracking Status
firefox56 --- fixed

People

(Reporter: lchang, Assigned: lchang)

References

(Blocks 1 open bug)

Details

(Whiteboard: [form autofill:M4])

Attachments

(1 file)

We should avoid picking another tel-related fields as a secondary label when we're already focusing a tel field.
Assignee: nobody → lchang
Status: NEW → ASSIGNED
Comment on attachment 8891895 [details]
Bug 1385753 - [Form Autofill] Group tel-related fields when calculating the secondary label.

https://reviewboard.mozilla.org/r/162916/#review168212

::: browser/extensions/formautofill/ProfileAutoCompleteResult.jsm:190
(Diff revision 2)
> +        "tel-country-code",
> +        "tel-national",
> +        "tel-area-code",
> +        "tel-local",
> +        "tel-local-prefix",
> +        "tel-local-suffix",

Should we add "tel-extension" here as well? Not sure, but I feel like they're related.
Comment on attachment 8891895 [details]
Bug 1385753 - [Form Autofill] Group tel-related fields when calculating the secondary label.

https://reviewboard.mozilla.org/r/162916/#review168214

LGTM, thanks :)
Attachment #8891895 - Flags: review?(ralin) → review+
Thanks for the review.


(In reply to Ray Lin[:ralin] from comment #3)
> Should we add "tel-extension" here as well? Not sure, but I feel like
> they're related.

They're related indeed. However, "tel-extension" isn't supported in MVP so I would prefer to add it until we need it.
Pushed by lchang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3a7473bd9db5
[Form Autofill] Group tel-related fields when calculating the secondary label. r=ralin
https://hg.mozilla.org/mozilla-central/rev/3a7473bd9db5
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.