Closed
Bug 1385803
Opened 7 years ago
Closed 7 years ago
Remove possiblyCalls override from MFromCodePoint
Categories
(Core :: JavaScript Engine: JIT, enhancement)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
mozilla56
Tracking | Status | |
---|---|---|
firefox56 | --- | fixed |
People
(Reporter: anba, Assigned: anba)
Details
Attachments
(1 file)
932 bytes,
patch
|
nbp
:
review+
|
Details | Diff | Splinter Review |
(M|L)FromCodePoint nowadays only calls into the VM when we can't allocate the JSThinInlineString inline, so we should probably remove the possiblyCalls override. And maybe we should also add ALLOW_CLONE(MFromCodePoint)?
Assignee | ||
Comment 1•7 years ago
|
||
The inlined FromCodePoint only has an OOL-call into the VM when we can't allocate the inline string in the generated code, so I don't think we still need to have the possiblyCalls() override in MFromCodePoint. And it should also be possible to mark MFromCodePoint as cloneable, shouldn't it? (But I don't know if there are any restrictions on when a MIR instruction can be marked as cloneable!)
Attachment #8891957 -
Flags: review?(nicolas.b.pierron)
Comment 2•7 years ago
|
||
Comment on attachment 8891957 [details] [diff] [review] bug1385803.patch Review of attachment 8891957 [details] [diff] [review]: ----------------------------------------------------------------- Making it cloneable is a nice to have for when we would enable Loop Unrolling optimization. Today cloneable instructions are mostly used for Range Analysis optimizations, where we clone the existing instruction into a recovered on bailout version of it.
Attachment #8891957 -
Flags: review?(nicolas.b.pierron) → review+
Assignee | ||
Comment 3•7 years ago
|
||
(In reply to Nicolas B. Pierron [:nbp] from comment #2) > Making it cloneable is a nice to have for when we would enable Loop > Unrolling optimization. > > Today cloneable instructions are mostly used for Range Analysis > optimizations, where we clone the existing instruction into a recovered on > bailout version of it. Thanks for the explanation!
Assignee | ||
Comment 4•7 years ago
|
||
Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=8997b7d045fca1be174dfedb8d14aa563e09a8bf
Keywords: checkin-needed
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/7adb18796c8f Remove possiblyCalls override from MFromCodePoint and make it cloneable. r=nbp
Keywords: checkin-needed
Comment 6•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/7adb18796c8f
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in
before you can comment on or make changes to this bug.
Description
•