Remove possiblyCalls override from MFromCodePoint

RESOLVED FIXED in Firefox 56

Status

()

RESOLVED FIXED
a year ago
a year ago

People

(Reporter: anba, Assigned: anba)

Tracking

Trunk
mozilla56
Points:
---

Firefox Tracking Flags

(firefox56 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

a year ago
(M|L)FromCodePoint nowadays only calls into the VM when we can't allocate the JSThinInlineString inline, so we should probably remove the possiblyCalls override.

And maybe we should also add ALLOW_CLONE(MFromCodePoint)?
(Assignee)

Comment 1

a year ago
Created attachment 8891957 [details] [diff] [review]
bug1385803.patch

The inlined FromCodePoint only has an OOL-call into the VM when we can't allocate the inline string in the generated code, so I don't think we still need to have the possiblyCalls() override in MFromCodePoint.

And it should also be possible to mark MFromCodePoint as cloneable, shouldn't it? (But I don't know if there are any restrictions on when a MIR instruction can be marked as cloneable!)
Attachment #8891957 - Flags: review?(nicolas.b.pierron)
Comment on attachment 8891957 [details] [diff] [review]
bug1385803.patch

Review of attachment 8891957 [details] [diff] [review]:
-----------------------------------------------------------------

Making it cloneable is a nice to have for when we would enable Loop Unrolling optimization.

Today cloneable instructions are mostly used for Range Analysis optimizations, where we clone the existing instruction into a recovered on bailout version of it.
Attachment #8891957 - Flags: review?(nicolas.b.pierron) → review+
(Assignee)

Comment 3

a year ago
(In reply to Nicolas B. Pierron [:nbp] from comment #2)
> Making it cloneable is a nice to have for when we would enable Loop
> Unrolling optimization.
> 
> Today cloneable instructions are mostly used for Range Analysis
> optimizations, where we clone the existing instruction into a recovered on
> bailout version of it.

Thanks for the explanation!

Comment 5

a year ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7adb18796c8f
Remove possiblyCalls override from MFromCodePoint and make it cloneable. r=nbp
Keywords: checkin-needed

Comment 6

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/7adb18796c8f
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.