Closed Bug 1385815 Opened 3 years ago Closed 3 years ago

Enable more ESLint rules for mobile/android (automatically fix)

Categories

(Firefox for Android :: General, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
Firefox 57
Tracking Status
firefox57 --- fixed

People

(Reporter: standard8, Assigned: dbugs, Mentored)

Details

Attachments

(4 files)

Now that Android has some ESLint rules enabled, we should remove the disabling of some of the rules so that we get closer to the general mozilla configuration.

In mobile/android/.eslintrc.js, we should be able to automatically fix some of the rules (note: split into several blocks, as we probably want to split this to make review easier):

- block-spacing
- comma-spacing
- eol-last
- key-spacing
- keyword-spacing
- no-trailing-spaces

- space-before-blocks
- space-before-function-paren
- space-infix-ops
- spaced-comment

- no-extra-semi
- no-else-return
- no-extra-bind
- no-multi-spaces
- no-useless-return
- no-lonely-if

- brace-style
- quotes
Comment on attachment 8892499 [details]
Bug 1385815 - Enable whitespace related ESLint rules for mobile/android.

https://reviewboard.mozilla.org/r/163464/#review171224
Attachment #8892499 - Flags: review?(s.kaspari) → review+
Comment on attachment 8892500 [details]
Bug 1385815 - Enable more whitespace related ESLint rules for mobile/android.

https://reviewboard.mozilla.org/r/163466/#review171228
Attachment #8892500 - Flags: review?(s.kaspari) → review+
Comment on attachment 8892501 [details]
Bug 1385815 - Enable more ESLint rules for mobile/android.

https://reviewboard.mozilla.org/r/163468/#review171230
Attachment #8892501 - Flags: review?(s.kaspari) → review+
Comment on attachment 8892502 [details]
Bug 1385815 - Enable brace-style and quotes ESLint rules for mobile/android.

https://reviewboard.mozilla.org/r/163470/#review171232
Attachment #8892502 - Flags: review?(s.kaspari) → review+
Nice! Thanks. :)
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s df6af8f0fe47 -d 91b30f63e8d8: rebasing 412136:df6af8f0fe47 "Bug 1385815 - Enable whitespace related ESLint rules for mobile/android. r=sebastian"
merging mobile/android/chrome/content/EmbedRT.js
merging mobile/android/chrome/content/PermissionsHelper.js
merging mobile/android/chrome/content/aboutAddons.js
merging mobile/android/components/LoginManagerPrompter.js
merging mobile/android/components/PromptService.js
merging mobile/android/components/SessionStore.js
merging mobile/android/modules/HelperApps.jsm
merging mobile/android/modules/Home.jsm
merging mobile/android/modules/JNI.jsm
merging mobile/android/modules/WebsiteMetadata.jsm
merging mobile/android/tests/browser/chrome/test_session_clear_history.html
merging mobile/android/tests/browser/robocop/robocop_head.js
warning: conflicts while merging mobile/android/chrome/content/EmbedRT.js! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b8312a6e31f4
Enable whitespace related ESLint rules for mobile/android. r=sebastian
https://hg.mozilla.org/integration/autoland/rev/704f6c7282a5
Enable more whitespace related ESLint rules for mobile/android. r=sebastian
https://hg.mozilla.org/integration/autoland/rev/20ffba01bb73
Enable more ESLint rules for mobile/android. r=sebastian
https://hg.mozilla.org/integration/autoland/rev/e195ec338cae
Enable brace-style and quotes ESLint rules for mobile/android. r=sebastian
You need to log in before you can comment on or make changes to this bug.