Closed Bug 1385833 Opened 7 years ago Closed 7 years ago

Simplify incremental sweeping a little

Categories

(Core :: JavaScript: GC, enhancement)

55 Branch
enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla56
Tracking Status
firefox56 --- fixed

People

(Reporter: jonco, Assigned: jonco)

Details

Attachments

(3 files)

Here are a few patches to simplify and tidy up incremental sweeping a little.
Attached patch 00-finalSplinter Review
Mark implementations of the SweepAction interface as 'final'.  I don't know whether this will actually make any difference but it's simple enough that we might as well.
Attached patch 01-namespaceSplinter Review
Move sweep actions to their own namespace and rename SweepForEachZone -> ForEachZoneInSweepGroup to clarify what that does.
Attachment #8891959 - Flags: review?(sphink)
Attachment #8891958 - Flags: review?(sphink)
Sweep JIT code and scripts in the same phase.  I don't know whether there was ever a requirement for these to be swept in separate phases but I tested that this works now.
Attachment #8891960 - Flags: review?(sphink)
Attachment #8891958 - Flags: review?(sphink) → review+
Attachment #8891959 - Flags: review?(sphink) → review+
Comment on attachment 8891960 [details] [diff] [review]
02-sweep-jitcode-with-script

Review of attachment 8891960 [details] [diff] [review]:
-----------------------------------------------------------------

I can't think of any reason offhand.
Attachment #8891960 - Flags: review?(sphink) → review+
Pushed by jcoppeard@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f2e435cfffbb
Simplify incremental sweeping and combine script and JIT code finalization phases r=sfink
https://hg.mozilla.org/mozilla-central/rev/f2e435cfffbb
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.