Closed
Bug 1385833
Opened 7 years ago
Closed 7 years ago
Simplify incremental sweeping a little
Categories
(Core :: JavaScript: GC, enhancement)
Tracking
()
RESOLVED
FIXED
mozilla56
Tracking | Status | |
---|---|---|
firefox56 | --- | fixed |
People
(Reporter: jonco, Assigned: jonco)
Details
Attachments
(3 files)
1.94 KB,
patch
|
sfink
:
review+
|
Details | Diff | Splinter Review |
4.33 KB,
patch
|
sfink
:
review+
|
Details | Diff | Splinter Review |
4.01 KB,
patch
|
sfink
:
review+
|
Details | Diff | Splinter Review |
Here are a few patches to simplify and tidy up incremental sweeping a little.
Assignee | ||
Comment 1•7 years ago
|
||
Mark implementations of the SweepAction interface as 'final'. I don't know whether this will actually make any difference but it's simple enough that we might as well.
Assignee | ||
Comment 2•7 years ago
|
||
Move sweep actions to their own namespace and rename SweepForEachZone -> ForEachZoneInSweepGroup to clarify what that does.
Attachment #8891959 -
Flags: review?(sphink)
Assignee | ||
Updated•7 years ago
|
Attachment #8891958 -
Flags: review?(sphink)
Assignee | ||
Comment 3•7 years ago
|
||
Sweep JIT code and scripts in the same phase. I don't know whether there was ever a requirement for these to be swept in separate phases but I tested that this works now.
Attachment #8891960 -
Flags: review?(sphink)
Updated•7 years ago
|
Attachment #8891958 -
Flags: review?(sphink) → review+
Updated•7 years ago
|
Attachment #8891959 -
Flags: review?(sphink) → review+
Comment 4•7 years ago
|
||
Comment on attachment 8891960 [details] [diff] [review] 02-sweep-jitcode-with-script Review of attachment 8891960 [details] [diff] [review]: ----------------------------------------------------------------- I can't think of any reason offhand.
Attachment #8891960 -
Flags: review?(sphink) → review+
Pushed by jcoppeard@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/f2e435cfffbb Simplify incremental sweeping and combine script and JIT code finalization phases r=sfink
Comment 6•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/f2e435cfffbb
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in
before you can comment on or make changes to this bug.
Description
•