Closed
Bug 1385838
Opened 7 years ago
Closed 7 years ago
Check for Symbol.iterator in ArgumentsObject::obj_mayResolve
Categories
(Core :: JavaScript Engine, enhancement)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla56
Tracking | Status | |
---|---|---|
firefox56 | --- | fixed |
People
(Reporter: jandem, Assigned: jandem)
Details
Attachments
(1 file)
1.36 KB,
patch
|
anba
:
review+
|
Details | Diff | Splinter Review |
As discussed in another bug. We can easily check for just Symbol.iterator instead of deoptimizing for all symbols.
Attachment #8891962 -
Flags: review?(andrebargull)
Assignee | ||
Comment 1•7 years ago
|
||
On Speedometer and a lot of websites the symbol != Symbol.iterator case hits a number of times, so hopefully this will help a bit somewhere. (I didn't log which symbol, could be toStringTag, toPrimitive, or something else.)
Comment 2•7 years ago
|
||
Comment on attachment 8891962 [details] [diff] [review] Patch Review of attachment 8891962 [details] [diff] [review]: ----------------------------------------------------------------- Thanks!
Attachment #8891962 -
Flags: review?(andrebargull) → review+
Pushed by jandemooij@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/1221530577aa Check for Symbol.iterator in ArgumentsObject::obj_mayResolve instead of returning true for all symbols. r=anba
Comment 4•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/1221530577aa
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in
before you can comment on or make changes to this bug.
Description
•