Closed Bug 1385848 Opened 4 years ago Closed 4 years ago

Make the chats tab icon adapt the tab text color

Categories

(Thunderbird :: Theme, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 56.0

People

(Reporter: Paenglab, Assigned: Paenglab)

Details

Attachments

(1 file)

Like we have already for the prefs tab icon adapting the text color of the tab text, we can do the same for the chat tab.
Attached patch chatIcon.patchSplinter Review
Instead of using the toolbar icon use our own for the tabs. The pro is also, we don't need special rules for the 18px toolbar icon.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8891976 - Flags: review?(jorgk)
Comment on attachment 8891976 [details] [diff] [review]
chatIcon.patch

Very nice.

Without the patch the chat icon can be black on a black inactive tab when choosing a dark accent colour in W10. So this is a must have.
Attachment #8891976 - Flags: review?(jorgk) → review+
Keywords: checkin-needed
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/b1fce827845e
Make the chats tab icon use the tab text color. r=jorgk
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 56.0
You need to log in before you can comment on or make changes to this bug.