1385904 - Remove NSPR_LOG* backward compatibility code from xpcom/Logging.cpp

Status: NEW

(Core :: XPCOM, enhancement)

Description

[Honza Bambas (:mayhemer)]

I think no one is using the old vars expecting xpcom and above code to log.  It's time to remove it, since when someone wants to log nspr these days (yes, it happens!) we want to avoid a stupid conflict.

Comment 1

[Honza Bambas (:mayhemer)]

Attachment: v1

Comment 2

[Nathan Froyd [:froydnj]]

Comment on attachment 8892031 [details] [diff] [review]
v1

Review of attachment 8892031 [details] [diff] [review]:
-----------------------------------------------------------------

I am cautiously in favor of this, but I am unsure of how much muscle/script memory this is going to break.  I think we at least need to fix:

https://dxr.mozilla.org/mozilla-central/source/security/sandbox/win/src/sandboxbroker/sandboxBroker.cpp#194

to take MOZ_LOG_FILE into account.  I guess we shouldn't remove the code at:

http://dxr.mozilla.org/mozilla-central/source/ipc/glue/GeckoChildProcessHost.cpp#496

and below, since people would want to log NSPR, and not handling those variables might cause issues.

Comment 3

[Eric Rahm [:erahm]]

Comment on attachment 8892031 [details] [diff] [review]
v1

Review of attachment 8892031 [details] [diff] [review]:
-----------------------------------------------------------------

::: xpcom/base/Logging.cpp
@@ -201,1 @@
>      NSPRLogModulesParser(modules,

We should probably rename this and update its comments when/if this lands.

Comment 4

[Eric Rahm [:erahm]]

Also of course we'd need to update the mdn docs.

Comment 5

[Honza Bambas (:mayhemer)]

I won't have time to work on this soon to fulfill the requests, hence rather releasing from my list for now.