Closed Bug 1385923 Opened 7 years ago Closed 7 years ago

The Pin to Overflow button shows twice on non-Photon builds

Categories

(Firefox :: Toolbars and Customization, defect, P1)

56 Branch
defect

Tracking

()

RESOLVED FIXED
Firefox 56
Iteration:
56.4 - Aug 1
Tracking Status
firefox56 --- fixed

People

(Reporter: jaws, Assigned: jaws)

References

Details

(Whiteboard: [reserve-photon-animation])

Attachments

(1 file)

STR:
Build with MOZ_PHOTON_THEME=0 and MOZ_PHOTON_ANIMATIONS=0
Pin an item to the overflow menu

ER:
Should see the overflow menu button

AR:
See the overflow menu button with two sets of icons inside of it
Flags: qe-verify?
Priority: -- → P3
Whiteboard: [photon-animation] → [reserve-photon-animation]
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Priority: P3 → --
Whiteboard: [reserve-photon-animation] → [photon-animation]
Iteration: --- → 56.4 - Aug 1
Priority: -- → P1
Whiteboard: [photon-animation] → [reserve-photon-animation]
Comment on attachment 8892054 [details]
Bug 1385923 - Only include the animatable-box for the overflow button in builds that support the animation.

https://reviewboard.mozilla.org/r/163064/#review168334
Attachment #8892054 - Flags: review?(gijskruitbosch+bugs) → review+
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/2654a14d9b3b
Only include the animatable-box for the overflow button in builds that support the animation. r=Gijs
https://hg.mozilla.org/mozilla-central/rev/2654a14d9b3b
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
Flags: qe-verify? → qe-verify-
You need to log in before you can comment on or make changes to this bug.